Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Maintenance: cleanup readme and vscode settings #5023

Merged
merged 7 commits into from
Nov 13, 2023
Merged

📝 Maintenance: cleanup readme and vscode settings #5023

merged 7 commits into from
Nov 13, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 13, 2023 •
edited
Loading

What do these changes do?

Taking advantage that I had to do a full installation from scratch I updated some of the doc and default settings

  • updates README: mainly installation instructions
  • updates vscode settings
    • launcher (rm invalid entries)
    • settings (rm deprecated entries)
    • recommended extensions

Related issue/s

None

How to test

None

DevOps

None

@pcrespov pcrespov self-assigned this Nov 13, 2023
@pcrespov pcrespov added this to the 7peaks milestone Nov 13, 2023
@pcrespov pcrespov changed the title 📝 WIP: Maintenance/updates setup 📝 Maintenance: cleanup readme and vscode settings Nov 13, 2023
@pcrespov pcrespov added a:doc documentation, reporting, admin tasks t:maintenance Some planned maintenance work labels Nov 13, 2023
@pcrespov pcrespov marked this pull request as ready for review November 13, 2023 17:22
@pcrespov pcrespov enabled auto-merge (squash) November 13, 2023 17:23
sanderegg
sanderegg reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks. Can you double check why you removed shellcheck?

.vscode/extensions.json Show resolved Hide resolved
.vscode/extensions.json Show resolved Hide resolved
.vscode/settings.template.json Show resolved Hide resolved
bisgaard-itis
bisgaard-itis approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for taking the opportunity to clean up.

.vscode/settings.template.json Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 13, 2023

Code Climate has analyzed commit a0056fa and detected 0 issues on this pull request.

View more on Code Climate.

@pcrespov pcrespov merged commit 9cabec0 into ITISFoundation:master Nov 13, 2023
49 checks passed
@pcrespov pcrespov deleted the maintenance/updates-setup branch November 13, 2023 21:33
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 14, 2023
Closed
17 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 23, 2023
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@pcrespov pcrespov

Labels
a:doc documentation, reporting, admin tasks t:maintenance Some planned maintenance work
Projects
None yet
Milestone
7peaks
Development

Successfully merging this pull request may close these issues.
4 participants
@pcrespov @sanderegg @matusdrobuliak66 @bisgaard-itis