Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ listen to wallet events in payment system #5012

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Nov 10, 2023

What do these changes do?

✨ listen to wallet events in the payment system

There will be 3 PRs:

  • listen to wallet events
  • move auto recharge functionality from the webserver to the payment service
  • make it idempotent (in case of payment service received multiple messages)

Related issue/s

How to test

new test services/payments/tests/unit/test_services_auto_recharge_listener.py

Dev Checklist

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 added this to the 7peaks milestone Nov 10, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review November 10, 2023 14:56
@matusdrobuliak66 matusdrobuliak66 self-assigned this Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #5012 (3b872d1) into master (19af489) will decrease coverage by 2.1%.
The diff coverage is 84.6%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #5012     +/-   ##
========================================
- Coverage    87.2%   85.2%   -2.1%     
========================================
  Files        1243     999    -244     
  Lines       51203   43118   -8085     
  Branches     1084     558    -526     
========================================
- Hits        44678   36760   -7918     
+ Misses       6286    6229     -57     
+ Partials      239     129    -110     
Flag Coverage Δ
integrationtests 63.5% <ø> (-1.5%) ⬇️
unittests 82.7% <84.6%> (-2.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...service-library/src/servicelib/rabbitmq/_client.py 100.0% <100.0%> (ø)
...s/src/simcore_service_payments/core/application.py 100.0% <100.0%> (ø)
.../src/simcore_service_payments/services/rabbitmq.py 96.8% <100.0%> (+6.8%) ⬆️
...ervice_payments/services/auto_recharge_listener.py 85.7% <85.7%> (ø)
...payments/services/auto_recharge_process_message.py 60.0% <60.0%> (ø)

... and 295 files with indirect coverage changes

@pcrespov pcrespov added the a:payments payments service label Nov 10, 2023
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) November 10, 2023 17:44
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that you do not want to delete the queue. but nevertheless the consumer of the queue should be deleted

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to understand the decorator. maybe you can tell me tomorrow.

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the PR is not fully ready

Copy link

sonarcloud bot commented Nov 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codeclimate bot commented Nov 13, 2023

Code Climate has analyzed commit 3b872d1 and detected 0 issues on this pull request.

View more on Code Climate.

@matusdrobuliak66 matusdrobuliak66 merged commit 22ebc0e into ITISFoundation:master Nov 13, 2023
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:payments payments service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants