-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ listen to wallet events in payment system #5012
✨ listen to wallet events in payment system #5012
Conversation
…iak66/osparc-simcore into is922/auto-recharge-emit-msg
Codecov Report
@@ Coverage Diff @@
## master #5012 +/- ##
========================================
- Coverage 87.2% 85.2% -2.1%
========================================
Files 1243 999 -244
Lines 51203 43118 -8085
Branches 1084 558 -526
========================================
- Hits 44678 36760 -7918
+ Misses 6286 6229 -57
+ Partials 239 129 -110
Flags with carried forward coverage won't be shown. Click here to find out more.
|
services/payments/src/simcore_service_payments/services/auto_recharge_listener.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that you do not want to delete the queue. but nevertheless the consumer of the queue should be deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to understand the decorator. maybe you can tell me tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the PR is not fully ready
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Code Climate has analyzed commit 3b872d1 and detected 0 issues on this pull request. View more on Code Climate. |
What do these changes do?
✨ listen to wallet events in the payment system
There will be 3 PRs:
Related issue/s
How to test
new test
services/payments/tests/unit/test_services_auto_recharge_listener.py
Dev Checklist
DevOps Checklist