-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Add user_id
to api server profile
#5002
🎨 Add user_id
to api server profile
#5002
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5002 +/- ##
=========================================
- Coverage 86.7% 81.1% -5.7%
=========================================
Files 1219 588 -631
Lines 50454 28812 -21642
Branches 1081 195 -886
=========================================
- Hits 43767 23368 -20399
+ Misses 6449 5395 -1054
+ Partials 238 49 -189
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor suggestion. thx
services/api-server/src/simcore_service_api_server/models/schemas/profiles.py
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Code Climate has analyzed commit a9a2a8d and detected 0 issues on this pull request. View more on Code Climate. |
What do these changes do?
user_id
to theget_profile
endpoint on the api-server. I will need this to investigate running instances in AWSRelated issue/s
How to test
DevOps Checklist