Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Add user_id to api server profile #5002

Conversation

bisgaard-itis
Copy link
Contributor

What do these changes do?

  • Add the user_id to the get_profile endpoint on the api-server. I will need this to investigate running instances in AWS

Related issue/s

How to test

DevOps Checklist

@bisgaard-itis bisgaard-itis self-assigned this Nov 8, 2023
@bisgaard-itis bisgaard-itis added the a:apiserver api-server service label Nov 8, 2023
@bisgaard-itis bisgaard-itis added this to the 7peaks milestone Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #5002 (a9a2a8d) into master (a1a618e) will decrease coverage by 5.7%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5002      +/-   ##
=========================================
- Coverage    86.7%   81.1%    -5.7%     
=========================================
  Files        1219     588     -631     
  Lines       50454   28812   -21642     
  Branches     1081     195     -886     
=========================================
- Hits        43767   23368   -20399     
+ Misses       6449    5395    -1054     
+ Partials      238      49     -189     
Flag Coverage Δ
integrationtests 63.5% <100.0%> (+9.2%) ⬆️
unittests 85.8% <100.0%> (+1.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...core_service_api_server/models/schemas/profiles.py 96.9% <100.0%> (+0.1%) ⬆️
...ver/src/simcore_service_webserver/users/schemas.py 98.3% <100.0%> (ø)

... and 772 files with indirect coverage changes

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor suggestion. thx

Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codeclimate bot commented Nov 8, 2023

Code Climate has analyzed commit a9a2a8d and detected 0 issues on this pull request.

View more on Code Climate.

@bisgaard-itis bisgaard-itis merged commit 5e85aad into ITISFoundation:master Nov 8, 2023
55 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 23, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:apiserver api-server service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants