✨ webserver: payments-method RCP client and new one-time payments with payment-method

[pcrespov]

What do these changes do?

This PR completes the last connection missing between the webserver/payments plugin and the payments service.
It adds the client-side of RPC API for payments-methods and mplements entrypoint for one-time-payment using given payment-method

• ✨ adds client methods for the api/rpc/_payment_methods API in the payments service
• ✨ services/webserver api version: 0.36.0 → 0.37.0:
  • exposes init_payment_with_payment_method: implements one-time payment using stored payment-method
  • New openapi.json specs
  • front-end:
    • resource payWithPaymentMethod
    • @ignapas @jsaq007 I need some help to double check that it is correctly connected/used.
• ♻️ ⚗️ Note that fake payment completion in the web-server (via PAYMENTS_FAKE_*) is still available until payment-gateway dev service is available. This code is also reused to fake the payments RPC api for testing. SEE services/web/server/tests/unit/with_dbs/03/wallets/payments/conftest.py::mock_rpc_payments_service_api
• ♻️ tests fixtures for with_dbs/03/wallets/payments

Related issue/s

• Implements part of Payments methods: add, remove, list and auto-recharge #4751

How to test

• Driving tests:

cd services/web/server
make install-dev
pytest -vv -k test_one_time_payment_with_payment_method tests/units

DevOps

Reminder, please ensure that

• master deploy PAYMENTS_FAKE_COMPLETION=1
• elsewhere PAYMENTS_FAKE_COMPLETION=0

[codecov]

Codecov Report

Merging #4979 (634f447) into master (73c5414) will increase coverage by 2.7%.
The diff coverage is 78.5%.

@@            Coverage Diff            @@
##           master   #4979      +/-   ##
=========================================
+ Coverage    78.7%   81.4%    +2.7%     
=========================================
  Files        1113     619     -494     
  Lines       46226   29731   -16495     
  Branches      722     195     -527     
=========================================
- Hits        36403   24222   -12181     
+ Misses       9664    5460    -4204     
+ Partials      159      49     -110     

Flag	Coverage Δ
integrationtests	63.5% <37.8%> (-1.7%)	⬇️
unittests	86.2% <78.5%> (+9.3%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...core_service_payments/api/rpc/_payments_methods.py	100.0% <ø> (ø)
...core_service_payments/services/payments_methods.py	91.8% <ø> (ø)
...re_service_webserver/wallets/_payments_handlers.py	98.5% <96.2%> (+39.2%)	⬆️
...simcore_service_webserver/payments/_onetime_api.py	97.6% <92.8%> (+56.9%)	⬆️
...simcore_service_webserver/payments/_methods_api.py	95.4% <89.5%> (+57.0%)	⬆️
...ver/src/simcore_service_webserver/payments/_rpc.py	58.2% <40.5%> (-4.3%)	⬇️

... and 724 files with indirect coverage changes

[matusdrobuliak66]

Looking good thanks 👍 (I would like to catch up sometimes in person about RPC methods and how/when to use them) Thanks!

[sanderegg]

Please check code climate warnings. you have some assertions without #nosec

[pcrespov]

Please check code climate warnings. you have some assertions without #nosec

That was before. Those comments are fixed.

[codeclimate]

Code Climate has analyzed commit 634f447 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
2.9% Duplication