Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix wrong error suppression #4841

Merged
merged 6 commits into from
Oct 9, 2023
Merged

🐛 Fix wrong error suppression #4841

merged 6 commits into from
Oct 9, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 9, 2023 •
edited
Loading

What do these changes do?

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK marked this pull request as ready for review October 9, 2023 11:19
@GitHK GitHK self-assigned this Oct 9, 2023
@GitHK GitHK added the a:director-v2 issue related with the director-v2 service label Oct 9, 2023
@GitHK GitHK added this to the the nameless milestone Oct 9, 2023
@GitHK GitHK requested a review from matusdrobuliak66 October 9, 2023 11:22
@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #4841 (a0cfb84) into master (ef973db) will decrease coverage by 19.9%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4841      +/-   ##
=========================================
- Coverage    86.5%   66.6%   -19.9%     
=========================================
  Files        1132     469     -663     
  Lines       47434   23895   -23539     
  Branches     1040       0    -1040     
=========================================
- Hits        41049   15933   -25116     
- Misses       6152    7962    +1810     
+ Partials      233       0     -233
Flag Coverage Δ
integrationtests 63.0% <ø> (-2.2%) ⬇️
unittests 84.7% <ø> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 909 files with indirect coverage changes

@GitHK GitHK requested a review from pcrespov October 9, 2023 12:41
@codeclimate
Copy link

codeclimate bot commented Oct 9, 2023

Code Climate has analyzed commit a0cfb84 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

pcrespov
pcrespov approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@GitHK GitHK enabled auto-merge (squash) October 9, 2023 14:02
@GitHK GitHK merged commit 2cda9fd into ITISFoundation:master Oct 9, 2023
This was referenced Oct 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

Assignees

@GitHK GitHK

Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Milestone
the nameless
Development

Successfully merging this pull request may close these issues.
3 participants
@GitHK @pcrespov @matusdrobuliak66