Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor products plugin before extension #4741

Merged
merged 13 commits into from
Sep 13, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Sep 12, 2023

What do these changes do?

Some refactoring work before #4739

  • runs ruff check --fix
  • created products.api
  • reviewed tests and fixtures
  • general cleanup

Related issue/s

How to test

in place

DevOps

None

@pcrespov pcrespov self-assigned this Sep 12, 2023
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Sep 12, 2023
@pcrespov pcrespov added this to the the nameless milestone Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #4741 (c747930) into master (0394294) will decrease coverage by 0.1%.
The diff coverage is 76.1%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4741     +/-   ##
========================================
- Coverage    86.0%   86.0%   -0.1%     
========================================
  Files        1112     989    -123     
  Lines       46596   42196   -4400     
  Branches     1013     497    -516     
========================================
- Hits        40113   36317   -3796     
+ Misses       6256    5772    -484     
+ Partials      227     107    -120     
Flag Coverage Δ
integrationtests 60.0% <61.9%> (+0.5%) ⬆️
unittests 85.4% <76.1%> (+0.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...r/src/simcore_service_webserver/products/_model.py 94.9% <60.0%> (-1.7%) ⬇️
...ver/src/simcore_service_webserver/products/_api.py 64.9% <64.9%> (ø)
.../src/simcore_service_webserver/products/_events.py 93.3% <72.7%> (-2.2%) ⬇️
...mcore_service_webserver/announcements/_handlers.py 100.0% <100.0%> (ø)
...r/src/simcore_service_webserver/email/_handlers.py 91.6% <100.0%> (ø)
.../src/simcore_service_webserver/groups/_handlers.py 82.1% <100.0%> (ø)
...rc/simcore_service_webserver/login/handlers_2fa.py 85.0% <100.0%> (ø)
...c/simcore_service_webserver/login/handlers_auth.py 98.0% <100.0%> (ø)
...simcore_service_webserver/login/handlers_change.py 87.8% <100.0%> (ø)
...e_service_webserver/login/handlers_confirmation.py 90.3% <100.0%> (ø)
... and 16 more

... and 181 files with indirect coverage changes

@pcrespov pcrespov marked this pull request as ready for review September 12, 2023 17:47
@pcrespov pcrespov force-pushed the is4546/refactor-products branch from a62e6b6 to 420a762 Compare September 12, 2023 22:51
@pcrespov pcrespov force-pushed the is4546/refactor-products branch from 420a762 to 19f9715 Compare September 13, 2023 07:18
@pcrespov pcrespov enabled auto-merge (squash) September 13, 2023 07:25
@codeclimate
Copy link

codeclimate bot commented Sep 13, 2023

Code Climate has analyzed commit c747930 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit 8a99304 into ITISFoundation:master Sep 13, 2023
@pcrespov pcrespov deleted the is4546/refactor-products branch September 13, 2023 12:55
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants