Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Autoscaling: prepare for computational autoscaling #4709

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 5, 2023

What do these changes do?

  • refactoring of code to prepare for computational cluster autoscaling

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added the a:autoscaling autoscaling service in simcore's stack label Sep 5, 2023
@sanderegg sanderegg added this to the Baklava milestone Sep 5, 2023
@sanderegg sanderegg self-assigned this Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #4709 (c17ccaa) into master (c634fb4) will increase coverage by 0.4%.
The diff coverage is 89.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4709     +/-   ##
========================================
+ Coverage    86.3%   86.8%   +0.4%     
========================================
  Files         858     883     +25     
  Lines       37133   38561   +1428     
  Branches      655     542    -113     
========================================
+ Hits        32078   33490   +1412     
- Misses       4907    4948     +41     
+ Partials      148     123     -25     
Flag Coverage Δ
integrationtests 65.3% <ø> (+<0.1%) ⬆️
unittests 84.1% <89.0%> (-2.4%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...toscaling/src/simcore_service_autoscaling/_meta.py 90.0% <ø> (ø)
...e_service_autoscaling/modules/auto_scaling_base.py 86.4% <86.4%> (ø)
...ervice_autoscaling/modules/auto_scaling_dynamic.py 96.0% <93.7%> (ø)
...rc/simcore_service_autoscaling/core/application.py 100.0% <100.0%> (ø)
...e_service_autoscaling/modules/auto_scaling_task.py 100.0% <100.0%> (ø)
...ing/src/simcore_service_autoscaling/modules/ec2.py 99.1% <100.0%> (ø)

... and 485 files with indirect coverage changes

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spotless! 🎉

MINOR: add a summary table of upgrades?

@sanderegg sanderegg force-pushed the autoscaling/read-dask-gateway-load branch 2 times, most recently from 210e939 to 6c20245 Compare September 5, 2023 14:58
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg sanderegg force-pushed the autoscaling/read-dask-gateway-load branch from 6c20245 to c17ccaa Compare September 5, 2023 19:07
@codeclimate
Copy link

codeclimate bot commented Sep 5, 2023

Code Climate has analyzed commit c17ccaa and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg merged commit 3e6b521 into ITISFoundation:master Sep 6, 2023
53 checks passed
@sanderegg sanderegg deleted the autoscaling/read-dask-gateway-load branch September 6, 2023 05:57
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:autoscaling autoscaling service in simcore's stack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants