Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 TIP v2: 3 plus buttons #4486

Merged
merged 6 commits into from
Jul 11, 2023
Merged

🎨 TIP v2: 3 plus buttons #4486

merged 6 commits into from
Jul 11, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jul 11, 2023 •
edited
Loading

What do these changes do?

  • 3 plus buttons
    • Classic TI
    • Multi-channel TI
    • Phase-modulated TI
  • Fix: boot mode update

image

Related issue/s

related to https://git.speag.com/oSparc/ti-solutions/-/issues/21

How to test

DevOps Checklist

@odeimaiz odeimaiz marked this pull request as ready for review July 11, 2023 11:16
@odeimaiz odeimaiz self-assigned this Jul 11, 2023
@odeimaiz odeimaiz added this to the Watermelon milestone Jul 11, 2023
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🎨enhancement labels Jul 11, 2023
@codeclimate
Copy link

codeclimate bot commented Jul 11, 2023

Code Climate has analyzed commit b694106 and detected 0 issues on this pull request.

View more on Code Climate.

bisgaard-itis
bisgaard-itis approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odeimaiz odeimaiz merged commit 56ea412 into ITISFoundation:master Jul 11, 2023
@odeimaiz odeimaiz deleted the feature/tip-v2-naming branch July 11, 2023 13:18
@odeimaiz odeimaiz modified the milestones: Watermelon, Sundae Jul 12, 2023
pcrespov pushed a commit that referenced this pull request Jul 13, 2023
@odeimaiz @pcrespov
🎨 TIP v2: 3 plus buttons (#4486)
5c7173d
@pcrespov pcrespov mentioned this pull request Jul 13, 2023
Closed
16 tasks
This was referenced Jul 19, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@GitHK GitHK Awaiting requested review from GitHK

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11

@elisabettai elisabettai Awaiting requested review from elisabettai

@pcrespov pcrespov Awaiting requested review from pcrespov

@mguidon mguidon Awaiting requested review from mguidon

@sanderegg sanderegg Awaiting requested review from sanderegg

@YuryHrytsuk YuryHrytsuk Awaiting requested review from YuryHrytsuk

@SCA-ZMT SCA-ZMT Awaiting requested review from SCA-ZMT

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
Sundae
Development

Successfully merging this pull request may close these issues.
3 participants
@odeimaiz @matusdrobuliak66 @bisgaard-itis