Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Maintenance/new python linting recipe #4320

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 6, 2023

What do these changes do?

Improves pylint recipe and configuration

  • Unifies pylint recipes (global and per-package)
  • Fixes some missing pylint issues (previous pylint recipe failed to detect some problems)
  • Fixes python linting jobs flakiness

Related issue/s

How to test

make devenv
make pylint

@pcrespov pcrespov added this to the Watermelon milestone Jun 6, 2023
@pcrespov pcrespov self-assigned this Jun 6, 2023
@pcrespov pcrespov force-pushed the maintenance/new-pylint-recipe branch from 978254b to 7b1b5f2 Compare June 6, 2023 09:37
@pcrespov pcrespov changed the title WIP:🔨 Maintenance/new pylint recipe 🔨 Maintenance/new python linting recipe Jun 6, 2023
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Jun 6, 2023
@pcrespov pcrespov marked this pull request as ready for review June 6, 2023 09:55
@pcrespov pcrespov requested a review from sanderegg as a code owner June 6, 2023 09:55
@codeclimate
Copy link

codeclimate bot commented Jun 6, 2023

Code Climate has analyzed commit cdb4fea and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov enabled auto-merge (squash) June 6, 2023 09:57
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #4320 (cdb4fea) into master (7274165) will decrease coverage by 19.5%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4320      +/-   ##
=========================================
- Coverage    85.6%   66.2%   -19.5%     
=========================================
  Files         977     393     -584     
  Lines       41868   20430   -21438     
  Branches      980     173     -807     
=========================================
- Hits        35873   13541   -22332     
- Misses       5773    6840    +1067     
+ Partials      222      49     -173     
Flag Coverage Δ
integrationtests 66.2% <ø> (-1.6%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 825 files with indirect coverage changes

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pcrespov pcrespov merged commit db74c94 into ITISFoundation:master Jun 6, 2023
@pcrespov pcrespov deleted the maintenance/new-pylint-recipe branch June 6, 2023 12:01
@pcrespov pcrespov mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky unit python-linting 3.10
3 participants