Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Frontend UI/UX: S4L logo, Sharee Permissions and Life Cycle view #4303

Merged
merged 21 commits into from
Jun 5, 2023
Merged

🎨 Frontend UI/UX: S4L logo, Sharee Permissions and Life Cycle view #4303

merged 21 commits into from
Jun 5, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 2, 2023 •
edited
Loading

What do these changes do?

  • New S4L logo (same as lite, but without the feather :( )
  • Sharee Permissions view
    • Warning-yellow icon on caption bar
    • Strong button appearance for the i button
  • Show update service option, if any, when the study is open. It was only visible when the service was eirther deprecated or retired.

Sharee Permissions view:
image

Update service
UpdateService

Related issue/s

closes ITISFoundation/osparc-issues#970

How to test

DevOps Checklist

@odeimaiz odeimaiz added this to the Pastel de Nata milestone Jun 2, 2023
@odeimaiz odeimaiz self-assigned this Jun 2, 2023
@odeimaiz odeimaiz changed the title WIP: 🎨 Feature/misc ii WIP: 🎨 Frontend aesthetics: S4L logo, Sharee Permissions and Life Cycle view Jun 2, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 5, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@odeimaiz odeimaiz changed the title WIP: 🎨 Frontend aesthetics: S4L logo, Sharee Permissions and Life Cycle view 🎨 Frontend aesthetics: S4L logo, Sharee Permissions and Life Cycle view Jun 5, 2023
@odeimaiz odeimaiz marked this pull request as ready for review June 5, 2023 09:34
@odeimaiz odeimaiz enabled auto-merge (squash) June 5, 2023 09:35
@odeimaiz odeimaiz changed the title 🎨 Frontend aesthetics: S4L logo, Sharee Permissions and Life Cycle view 🎨 Frontend UI/UX: S4L logo, Sharee Permissions and Life Cycle view Jun 5, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 5, 2023

Code Climate has analyzed commit 7cf637e and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

pcrespov
pcrespov reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mguidon
mguidon approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🎨enhancement labels Jun 5, 2023
@odeimaiz odeimaiz modified the milestones: Pastel de Nata, Watermelon Jun 5, 2023
elisabettai
elisabettai approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks!
I would also make the "Sharee permission" text yellow. 😉

@odeimaiz odeimaiz merged commit 1d15b8d into ITISFoundation:master Jun 5, 2023
@odeimaiz odeimaiz deleted the feature/misc-ii branch June 5, 2023 10:20
matusdrobuliak66
matusdrobuliak66 reviewed Jun 5, 2023
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz mentioned this pull request Jun 9, 2023
Closed
This was referenced Jun 13, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 left review comments

@pcrespov pcrespov pcrespov left review comments

@mguidon mguidon mguidon approved these changes

@elisabettai elisabettai elisabettai approved these changes

@GitHK GitHK Awaiting requested review from GitHK

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
Watermelon
Development

Successfully merging this pull request may close these issues.

Function to update the service from within the study is missing
5 participants
@odeimaiz @elisabettai @pcrespov @mguidon @matusdrobuliak66