Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Removes permalink log-debug message #4298

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 1, 2023

What do these changes do?

  • Removes unfortunate DEBUG log messages like
Failed to create permalink Can only create permalink from a template project. Got project_uuid=... with project_type=<ProjectType.STANDARD: 'STANDARD'>

that suggested a failure but in reality was a handled exception with an old debug message used during development.

  • Lessons learned: generally DEBUG messages should never log Failures

Related issue/s

@pcrespov pcrespov requested a review from mrnicegyu11 June 1, 2023 18:24
@pcrespov pcrespov self-assigned this Jun 1, 2023
@pcrespov pcrespov added changelog:🐛bugfix a:webserver issue related to the webserver service labels Jun 1, 2023
@pcrespov pcrespov added this to the Pastel de Nata milestone Jun 1, 2023
@pcrespov pcrespov enabled auto-merge (squash) June 1, 2023 18:26
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #4298 (8d4c91b) into master (0e80ae6) will decrease coverage by 1.7%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4298      +/-   ##
=========================================
- Coverage    85.5%   83.9%    -1.7%     
=========================================
  Files         965     393     -572     
  Lines       41140   20407   -20733     
  Branches      978     173     -805     
=========================================
- Hits        35189   17125   -18064     
+ Misses       5729    3233    -2496     
+ Partials      222      49     -173     
Flag Coverage Δ
integrationtests 66.2% <100.0%> (-1.7%) ⬇️
unittests 86.1% <100.0%> (+3.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/simcore_service_webserver/projects/_permalink.py 97.5% <100.0%> (-0.1%) ⬇️

... and 658 files with indirect coverage changes

@pcrespov pcrespov force-pushed the is4284/fixes-permalink-log-message branch from 257c410 to 3b722d6 Compare June 2, 2023 13:51
@codeclimate
Copy link

codeclimate bot commented Jun 2, 2023

Code Climate has analyzed commit 8d4c91b and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit 11f0fbd into ITISFoundation:master Jun 2, 2023
@pcrespov pcrespov deleted the is4284/fixes-permalink-log-message branch June 7, 2023 10:50
@pcrespov pcrespov restored the is4284/fixes-permalink-log-message branch June 7, 2023 10:51
@pcrespov pcrespov deleted the is4284/fixes-permalink-log-message branch June 7, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log-spamming: permalink failed to create
3 participants