Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Frontend enh: Center tab icons #4295

Merged
merged 9 commits into from
Jun 1, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 1, 2023

What do these changes do?

I finally figured out why icons on tab pages are not centered. This PR will help you with your OCD.

Before (navbar buttons):
image

After (navbar buttons):
image

Before (buttons on the left):
image

After (buttons on the left):
image

Related issue/s

How to test

DevOps Checklist

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🎨enhancement labels Jun 1, 2023
@odeimaiz odeimaiz added this to the Pastel de Nata milestone Jun 1, 2023
@odeimaiz odeimaiz self-assigned this Jun 1, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 1, 2023

Code Climate has analyzed commit cc46b8d and detected 0 issues on this pull request.

View more on Code Climate.

@odeimaiz odeimaiz marked this pull request as ready for review June 1, 2023 14:39
@odeimaiz odeimaiz enabled auto-merge (squash) June 1, 2023 14:40
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subtle :-)

@sanderegg sanderegg disabled auto-merge June 1, 2023 15:32
@sanderegg sanderegg merged commit 5c86827 into ITISFoundation:master Jun 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 14, 2023
25 tasks
@odeimaiz odeimaiz deleted the feature/center-tab-icons branch August 20, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants