-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Frontend enh: Center tab icons #4295
Merged
sanderegg
merged 9 commits into
ITISFoundation:master
from
odeimaiz:feature/center-tab-icons
Jun 1, 2023
Merged
🎨 Frontend enh: Center tab icons #4295
sanderegg
merged 9 commits into
ITISFoundation:master
from
odeimaiz:feature/center-tab-icons
Jun 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
a:frontend
issue affecting the front-end (area group)
changelog:🎨enhancement
labels
Jun 1, 2023
Code Climate has analyzed commit cc46b8d and detected 0 issues on this pull request. View more on Code Climate. |
odeimaiz
requested review from
GitHK,
mrnicegyu11,
elisabettai,
pcrespov,
mguidon,
sanderegg and
matusdrobuliak66
June 1, 2023 14:40
elisabettai
approved these changes
Jun 1, 2023
pcrespov
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subtle :-)
sanderegg
approved these changes
Jun 1, 2023
Kudos, SonarCloud Quality Gate passed! |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
I finally figured out why icons on tab pages are not centered. This PR will help you with your OCD.
Before (navbar buttons):
After (navbar buttons):
Before (buttons on the left):
After (buttons on the left):
Related issue/s
How to test
DevOps Checklist