-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Move filtering to backend (part 1) #4283
✨ Move filtering to backend (part 1) #4283
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4283 +/- ##
=========================================
- Coverage 85.8% 79.2% -6.6%
=========================================
Files 976 399 -577
Lines 41989 20754 -21235
Branches 965 173 -792
=========================================
- Hits 36034 16456 -19578
+ Misses 5734 4249 -1485
+ Partials 221 49 -172
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
- Note that there is a trick to reuse the pydantic models defined in handlers_crud as query/parameters in api/specs/webserver/scripts
- Can you please add the references you used (and describes above) in the code as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the comments.
Very nice and looking forward to this backend search
services/web/server/src/simcore_service_webserver/projects/_crud_read_utils.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_handlers_crud.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_handlers_crud.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_handlers_crud.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_handlers_crud.py
Outdated
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/02/test_projects_handlers__list_search.py
Outdated
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/02/test_projects_handlers__list_search.py
Outdated
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/02/test_projects_handlers__list_search.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the comments.
Very nice and looking forward to this backend search
…66/osparc-simcore into move-filtering-to-backend
…66/osparc-simcore into move-filtering-to-backend
Code Climate has analyzed commit 45e5157 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
What do these changes do?
These changes introduce 3 new query parameters in the list projects api (NOTE: Only the search query parameter is currently added to the OAS and implemented in the backend!)
search
Search is implemented by this PR, it is a full-text search on more columns, currently: project name, description, uuid, and user name.
order_by
filtering
Related issue/s
How to test
Webserver
DevOps Checklist