Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Uniformize Dockerfiles #4275

Merged
merged 14 commits into from
Jun 7, 2023
Merged

♻️ Uniformize Dockerfiles #4275

merged 14 commits into from
Jun 7, 2023

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented May 26, 2023 •
edited
Loading

What do these changes do?

  • make use of buildx caching
  • uniformize Dockerfile among services
  • fix access rights to /home/scu (in particular the base folder (/home/scu) were not set so that user scu could write to that folder. This was causing issues in the resource-usage-tracker and dask-scheduler
  • add ENV variables to pass to resources-usage-tracker service

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added a:storage issue related to storage service a:director issue related with the director service a:webserver issue related to the webserver service a:sidecar issue related with the sidecar worker service a:catalog catalog service a:director-v2 issue related with the director-v2 service a:apiserver api-server service a:dynamic-sidecar dynamic-sidecar service a:dask-service Any of the dask services: dask-scheduler/sidecar or worker a:autoscaling autoscaling service in simcore's stack a:agent agent service a:invitations invitations service a:resource-usage-tracker resource usage tracker service labels May 26, 2023
@sanderegg sanderegg added this to the Pastel de Nata milestone May 26, 2023
@sanderegg sanderegg self-assigned this May 26, 2023
@sanderegg sanderegg changed the title ♻️ Uniformize Dockefiles ♻️ Uniformize Dockerfiles May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023 •
edited
Loading

Codecov Report

Merging #4275 (0af23e0) into master (bf838aa) will decrease coverage by 9.3%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4275     +/-   ##
========================================
- Coverage    84.9%   75.6%   -9.3%     
========================================
  Files         792     686    -106     
  Lines       35710   29692   -6018     
  Branches      797     602    -195     
========================================
- Hits        30323   22471   -7852     
- Misses       5207    7081   +1874     
+ Partials      180     140     -40
Flag Coverage Δ
integrationtests 67.9% <ø> (+<0.1%) ⬆️
unittests 70.9% <ø> (-11.7%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 669 files with indirect coverage changes

@sanderegg sanderegg force-pushed the maintenance/improved_docker_files branch 2 times, most recently from 80ad8fe to 42e233d Compare May 26, 2023 12:24
@sanderegg sanderegg requested a review from mguidon May 26, 2023 12:28
GitHK
GitHK approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

packages/postgres-database/docker/Dockerfile Outdated Show resolved Hide resolved
mguidon
mguidon approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a question

services/agent/Dockerfile Show resolved Hide resolved
@sanderegg sanderegg force-pushed the maintenance/improved_docker_files branch 2 times, most recently from cde811a to aaebf8a Compare May 30, 2023 08:26
@sanderegg sanderegg force-pushed the maintenance/improved_docker_files branch from aaebf8a to 87ba853 Compare May 30, 2023 12:49
@sanderegg sanderegg force-pushed the maintenance/improved_docker_files branch 4 times, most recently from 67f1b25 to ff88eb1 Compare June 6, 2023 21:06
mrnicegyu11
mrnicegyu11 approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@sanderegg sanderegg force-pushed the maintenance/improved_docker_files branch from b930b8f to a92c820 Compare June 7, 2023 09:51
@sanderegg sanderegg requested a review from odeimaiz as a code owner June 7, 2023 10:09
@codeclimate
Copy link

codeclimate bot commented Jun 7, 2023

Code Climate has analyzed commit 0af23e0 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg merged commit 5abbddd into ITISFoundation:master Jun 7, 2023
@sanderegg sanderegg deleted the maintenance/improved_docker_files branch June 7, 2023 19:15
This was referenced Jun 13, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguidon mguidon mguidon approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@pcrespov pcrespov pcrespov approved these changes

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@GitHK GitHK GitHK approved these changes

@Surfict Surfict Awaiting requested review from Surfict

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66 matusdrobuliak66 is a code owner

Assignees

@sanderegg sanderegg

Labels
a:agent agent service a:apiserver api-server service a:autoscaling autoscaling service in simcore's stack a:catalog catalog service a:dask-service Any of the dask services: dask-scheduler/sidecar or worker a:director issue related with the director service a:director-v2 issue related with the director-v2 service a:dynamic-sidecar dynamic-sidecar service a:invitations invitations service a:resource-usage-tracker resource usage tracker service a:sidecar issue related with the sidecar worker service a:storage issue related to storage service a:webserver issue related to the webserver service
Projects
None yet
Milestone
Pastel de Nata
Development

Successfully merging this pull request may close these issues.
6 participants
@sanderegg @GitHK @mrnicegyu11 @pcrespov @odeimaiz @mguidon