Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ improving local log format #4270

Merged
merged 5 commits into from
May 25, 2023
Merged

♻️ improving local log format #4270

merged 5 commits into from
May 25, 2023

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented May 25, 2023 •
edited
Loading

What do these changes do?

  • Changing log format for local development

Related issue/s

How to test

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023 •
edited
Loading

Codecov Report

Merging #4270 (f577ec7) into master (fc599c5) will decrease coverage by 1.7%.
The diff coverage is 20.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4270      +/-   ##
=========================================
- Coverage    83.7%   82.1%    -1.7%     
=========================================
  Files         957     434     -523     
  Lines       41541   14469   -27072     
  Branches      963     791     -172     
=========================================
- Hits        34800   11881   -22919     
+ Misses       6520    2415    -4105     
+ Partials      221     173      -48
Flag Coverage Δ
integrationtests ?
unittests 82.1% <20.0%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/service-library/src/servicelib/logging_utils.py 70.0% <20.0%> (-1.4%) ⬇️

... and 526 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 added the t:maintenance Some planned maintenance work label May 25, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Pastel de Nata milestone May 25, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review May 25, 2023 08:20
sanderegg
sanderegg approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@codeclimate
Copy link

codeclimate bot commented May 25, 2023

Code Climate has analyzed commit f577ec7 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg merged commit e355cca into ITISFoundation:master May 25, 2023
This was referenced May 30, 2023
Closed
Closed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 14, 2023
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg approved these changes

@Surfict Surfict Awaiting requested review from Surfict

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11 mrnicegyu11 is a code owner

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels
t:maintenance Some planned maintenance work
Projects
None yet
Milestone
Pastel de Nata
Development

Successfully merging this pull request may close these issues.
2 participants
@matusdrobuliak66 @sanderegg