✨Saving volume stats inside the shared store volume

[GitHK]

What do these changes do?

It is necessary to store the state of the volumes somewhere. Since the sidecar has exclusive access to the shared store volume, it will not have any permission or ownership issues when trying to write the states there.

Contents of the SharedStore (snapshot while outputs and state are being saved):

{
  ...
  "volume_states": {
    "INPUTS": {
      "status": "CONTENT_NO_SAVE_REQUIRED",
      "last_changed": "2023-05-30T08:59:48.723425+00:00"
    },
    "SHARED_STORE": {
      "status": "CONTENT_NO_SAVE_REQUIRED",
      "last_changed": "2023-05-30T08:59:48.723459+00:00"
    },
    "OUTPUTS": {
      "status": "CONTENT_WAS_SAVED",
      "last_changed": "2023-05-30T09:00:59.297894+00:00"
    },
    "STATES": {
      "status": "CONTENT_NEEDS_TO_BE_SAVED",
      "last_changed": "2023-05-30T08:59:49.559358+00:00"
    }
  }
}

Bonus: minor models-library cleanup

Related issue/s

• closes volumes state is stored in the state volume inside the dy-sidecar osparc-issues#962
• improving dynamic-sidecar design osparc-issues#638
• followup to ✨ Volumes keep track of their data's state #4228
• brings back changes from ♻️ Volumes keep track if the data requires saving 🚨 #3974
• required by ♻️ volumes are removed via agent (⚠️ devops) #3941

How to test

DevOps Checklist

[codecov]

Codecov Report

Merging #4267 (645369f) into master (a0c455a) will increase coverage by 7.0%.
The diff coverage is 95.2%.

@@           Coverage Diff            @@
##           master   #4267     +/-   ##
========================================
+ Coverage    79.8%   86.9%   +7.0%     
========================================
  Files         938     818    -120     
  Lines       39877   37622   -2255     
  Branches      965     456    -509     
========================================
+ Hits        31860   32703    +843     
+ Misses       7796    4810   -2986     
+ Partials      221     109    -112     

Flag	Coverage Δ
integrationtests	68.7% <100.0%> (+21.0%)	⬆️
unittests	83.4% <91.5%> (+1.6%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ages/models-library/src/models_library/services.py	94.1% <ø> (ø)
...brary/src/models_library/utils/fastapi_encoders.py	100.0% <ø> (ø)
...ore_service_dynamic_sidecar/models/shared_store.py	90.1% <85.7%> (ø)
...models-library/src/models_library/aiodocker_api.py	74.0% <100.0%> (-1.0%)	⬇️
...ages/models-library/src/models_library/clusters.py	100.0% <100.0%> (ø)
...tion_services_catalog/services/iter_sensitivity.py	48.1% <100.0%> (ø)
...dels-library/src/models_library/sidecar_volumes.py	100.0% <100.0%> (ø)
...rc/models_library/utils/database_models_factory.py	88.4% <100.0%> (ø)
...r_v2/modules/dynamic_sidecar/api_client/_public.py	92.7% <100.0%> (+53.8%)	⬆️
...tor_v2/modules/dynamic_sidecar/api_client/_thin.py	100.0% <100.0%> (+40.9%)	⬆️
... and 4 more

... and 295 files with indirect coverage changes

[sanderegg]

nice! some comments

[codeclimate]

Code Climate has analyzed commit 645369f and detected 0 issues on this pull request.

View more on Code Climate.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.1% Duplication