-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ defines openapi specs for new studies resources #4250
✨ defines openapi specs for new studies resources #4250
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4250 +/- ##
========================================
+ Coverage 83.7% 86.0% +2.2%
========================================
Files 974 817 -157
Lines 41921 36160 -5761
Branches 964 551 -413
========================================
- Hits 35112 31113 -3999
+ Misses 6601 4915 -1686
+ Partials 208 132 -76
Flags with carried forward coverage won't be shown. Click here to find out more.
|
f41a677
to
4fad595
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just a single suggestion and a question.
services/api-server/src/simcore_service_api_server/api/routes/studies.py
Outdated
Show resolved
Hide resolved
b5d3fe9
to
86604d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe listen to what DK has to say about the env vars
Code Climate has analyzed commit a0bbd5c and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Drafts the openapi specs (OAS) for a new
studies
collections and missing operations in current resources. NOTE that this PR only addresses the OAS, i.e. all handlers will raiseNotImplementeError
if queried and are only active in withAPI_SERVER_DEV_FEATURES_ENABLED=1
The idea of this PR is to draft the interface and create tests for the issues requested so far as a starting point for its implementation.
Highlights
studies
collectionsmake openapi-dev.json
produces OAS withAPI_SERVER_DEV_FEATURES_ENABLED=1
Related issue/s
How to test
openapi-dev.json
so the review can explore the new definitions using https://petstore.swagger.io/?url=https://raw.githubusercontent.com/ITISFoundation/osparc-simcore/b95953661d79408f2ef88b100ed2b2a9ed3b7b97/services/api-server/openapi-dev.jsonFollow up