Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ defines openapi specs for new studies resources #4250

Merged
merged 20 commits into from
May 30, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented May 17, 2023

What do these changes do?

Drafts the openapi specs (OAS) for a new studies collections and missing operations in current resources. NOTE that this PR only addresses the OAS, i.e. all handlers will raise NotImplementeError if queried and are only active in with API_SERVER_DEV_FEATURES_ENABLED=1

The idea of this PR is to draft the interface and create tests for the issues requested so far as a starting point for its implementation.

Highlights

  • ✨ OAS for studies collections
  • ✨ OAS missing operations in current resources (see related issues)
  • 🔨 make openapi-dev.json produces OAS with API_SERVER_DEV_FEATURES_ENABLED=1

Related issue/s

How to test

Follow up

  • @bisgaard-itis can you try to create the client?
  • @sanderegg I would like to check with you how to connect some of the implementations

@pcrespov pcrespov self-assigned this May 17, 2023
@pcrespov pcrespov added a:api framework api, data schemas, a:apiserver api-server service labels May 17, 2023
@pcrespov pcrespov added this to the Pastel de Nata milestone May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #4250 (a0bbd5c) into master (b004ab1) will increase coverage by 2.2%.
The diff coverage is 81.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4250     +/-   ##
========================================
+ Coverage    83.7%   86.0%   +2.2%     
========================================
  Files         974     817    -157     
  Lines       41921   36160   -5761     
  Branches      964     551    -413     
========================================
- Hits        35112   31113   -3999     
+ Misses       6601    4915   -1686     
+ Partials      208     132     -76     
Flag Coverage Δ
integrationtests 67.2% <ø> (+17.0%) ⬆️
unittests 82.7% <81.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/simcore_service_api_server/api/routes/studies.py 90.0% <71.4%> (-10.0%) ⬇️
.../service-library/src/servicelib/fastapi/openapi.py 75.8% <75.0%> (ø)
...core_service_api_server/api/routes/studies_jobs.py 77.5% <77.5%> (ø)
...-server/src/simcore_service_api_server/api/root.py 100.0% <100.0%> (ø)
...c/simcore_service_api_server/api/routes/_common.py 100.0% <100.0%> (ø)
...core_service_api_server/api/routes/solvers_jobs.py 62.0% <100.0%> (+1.9%) ⬆️
...mcore_service_api_server/models/schemas/studies.py 100.0% <100.0%> (ø)

... and 217 files with indirect coverage changes

@pcrespov pcrespov force-pushed the is4177/openapi-specs-studies branch 3 times, most recently from f41a677 to 4fad595 Compare May 22, 2023 19:40
@pcrespov pcrespov changed the title WIP: ✨ Is4177/openapi specs studies ✨ defines openapi specs for new studies resources May 22, 2023
@pcrespov pcrespov marked this pull request as ready for review May 22, 2023 20:36
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a single suggestion and a question.

services/api-server/Makefile Show resolved Hide resolved
@pcrespov pcrespov force-pushed the is4177/openapi-specs-studies branch from b5d3fe9 to 86604d7 Compare May 23, 2023 12:32
@pcrespov pcrespov requested a review from GitHK May 23, 2023 12:33
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe listen to what DK has to say about the env vars

@pcrespov pcrespov requested a review from GitHK May 23, 2023 15:17
@pcrespov pcrespov enabled auto-merge (squash) May 23, 2023 20:25
@codeclimate
Copy link

codeclimate bot commented May 30, 2023

Code Climate has analyzed commit a0bbd5c and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit 51e48c3 into ITISFoundation:master May 30, 2023
@pcrespov pcrespov deleted the is4177/openapi-specs-studies branch June 1, 2023 16:43
@pcrespov pcrespov restored the is4177/openapi-specs-studies branch June 1, 2023 16:44
@pcrespov pcrespov deleted the is4177/openapi-specs-studies branch June 1, 2023 17:32
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 14, 2023
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:api framework api, data schemas, a:apiserver api-server service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants