✨Propagate key and version to dy-sidecar service labels #4249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matusdrobuliak66
approved these changes
May 17, 2023
pcrespov
approved these changes
May 17, 2023
Codecov Report
@@ Coverage Diff @@
## master #4249 +/- ##
=========================================
- Coverage 85.5% 63.6% -22.0%
=========================================
Files 836 397 -439
Lines 36845 20619 -16226
Branches 587 173 -414
=========================================
- Hits 31520 13116 -18404
- Misses 5188 7454 +2266
+ Partials 137 49 -88
Flags with carried forward coverage won't be shown. Click here to find out more.
|
added 2 commits
May 18, 2023 09:09
…key-version-to-new-style-labels
|
Code Climate has analyzed commit 7242547 and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The dynamic-sidecar service will also contain the user service's
keyandversion. For the case of multi container services only the key and version of the container started in the GUI will be displayed.Related issue/s
How to test
DevOps Checklist