Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 is767 optimization example #4248

Merged
merged 15 commits into from
May 22, 2023
Merged

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented May 17, 2023

What do these changes do?

Add a numerical optimization example which runs an optimization algorithm on the host machine, but each call to the objective function is executed on oSparc using oSparc's public API. This demonstrates that Sim4Life and oSparc can work together to create a powerful tool for determining optimal simulation parameters.

Related issue/s

ITISFoundation/osparc-issues#767

How to test

Run the example.

DevOps Checklist

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #4248 (872c706) into master (843e244) will decrease coverage by 5.7%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4248     +/-   ##
========================================
- Coverage    82.3%   76.6%   -5.7%     
========================================
  Files         957     832    -125     
  Lines       41505   36344   -5161     
  Branches      963     587    -376     
========================================
- Hits        34177   27872   -6305     
- Misses       7107    8334   +1227     
+ Partials      221     138     -83     
Flag Coverage Δ
integrationtests 68.9% <ø> (+0.1%) ⬆️
unittests 81.9% <ø> (+3.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 235 files with indirect coverage changes

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Please remove artifacts and tokens :-) (renovate also tokens in the UI please ASAP!! ;-) )

I also add some tips!

tests/public-api/examples/optimization/solver.py Outdated Show resolved Hide resolved
tests/public-api/examples/optimization/solver.py Outdated Show resolved Hide resolved
tests/public-api/examples/optimization/solution.npy Outdated Show resolved Hide resolved
tests/public-api/examples/optimization/example.py Outdated Show resolved Hide resolved
tests/public-api/examples/optimization/solver.py Outdated Show resolved Hide resolved
tests/public-api/examples/optimization/solver.py Outdated Show resolved Hide resolved
Copy link
Contributor

@colinRawlings colinRawlings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great mads - just some minor (and probably mis-guided) suggestions so that you know I read it

tests/public-api/examples/optimization/example.py Outdated Show resolved Hide resolved
tests/public-api/examples/optimization/example.py Outdated Show resolved Hide resolved
tests/public-api/examples/optimization/example.py Outdated Show resolved Hide resolved
tests/public-api/examples/optimization/example.py Outdated Show resolved Hide resolved
tests/public-api/examples/optimization/example.py Outdated Show resolved Hide resolved
tests/public-api/examples/optimization/solver.py Outdated Show resolved Hide resolved
tests/public-api/examples/optimization/solver.py Outdated Show resolved Hide resolved
tests/public-api/examples/optimization/solver.py Outdated Show resolved Hide resolved
tests/public-api/examples/optimization/solver.py Outdated Show resolved Hide resolved
tests/public-api/examples/optimization/solver.py Outdated Show resolved Hide resolved
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5377 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5380 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5378 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5376 lines exceeds the maximum allowed for the inline comments feature.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

tests/public-api/examples/optimization/example.py Outdated Show resolved Hide resolved
@pcrespov pcrespov added the a:doc documentation, reporting, admin tasks label May 17, 2023
@pcrespov pcrespov added this to the Pastel de Nata milestone May 17, 2023
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5376 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5445 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5436 lines exceeds the maximum allowed for the inline comments feature.

@bisgaard-itis
Copy link
Contributor Author

@pcrespov and @colinRawlings are you happy if I resolve all conversations above and merge?

@bisgaard-itis
Copy link
Contributor Author

@pcrespov and @colinRawlings are you happy if I resolve all conversations above and merge?

Actually it seems I cannot resolve the comments. I guess that is because you would have to resolve them for me(?)

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5436 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented May 22, 2023

Code Climate has analyzed commit 872c706 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bisgaard-itis bisgaard-itis merged commit b13a831 into master May 22, 2023
@bisgaard-itis bisgaard-itis deleted the 767-optimization-example branch May 22, 2023 11:31
@matusdrobuliak66 matusdrobuliak66 changed the title 767 optimization example 🔨 is767 optimization example May 23, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:doc documentation, reporting, admin tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants