-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 is767 optimization example #4248
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4248 +/- ##
========================================
- Coverage 82.3% 76.6% -5.7%
========================================
Files 957 832 -125
Lines 41505 36344 -5161
Branches 963 587 -376
========================================
- Hits 34177 27872 -6305
- Misses 7107 8334 +1227
+ Partials 221 138 -83
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Please remove artifacts and tokens :-) (renovate also tokens in the UI please ASAP!! ;-) )
I also add some tips!
tests/public-api/examples/optimization/gaussian_process_plot.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great mads - just some minor (and probably mis-guided) suggestions so that you know I read it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5377 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5380 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5378 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5376 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5376 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5445 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5436 lines exceeds the maximum allowed for the inline comments feature.
@pcrespov and @colinRawlings are you happy if I resolve all conversations above and merge? |
Actually it seems I cannot resolve the comments. I guess that is because you would have to resolve them for me(?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 5436 lines exceeds the maximum allowed for the inline comments feature.
Code Climate has analyzed commit 872c706 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! |
What do these changes do?
Add a numerical optimization example which runs an optimization algorithm on the host machine, but each call to the objective function is executed on oSparc using oSparc's public API. This demonstrates that Sim4Life and oSparc can work together to create a powerful tool for determining optimal simulation parameters.
Related issue/s
ITISFoundation/osparc-issues#767
How to test
Run the example.
DevOps Checklist