✅ Fixes flaky test api-server #3569

[pcrespov]

What do these changes do?

• ✅ ♻️ cleanup test/public-api
• 🐛 fixes failing docker log dumps issue that avoided producing container log artifacts.
• Temporary disables failing test until logs policy in the director-v2 is clarified

Insight on Failing Test

• In the public-api tests, I run a sleeper that will exit with failure (there is a flag to force it).
• Then I try to download the logsfile for the failing sleeper but it does not exits
• Tracing the issue i noticed that the directorv2 actually is deleting the logsfile (and the outputs) because the job failed https://github.com/ITISFoundation/osparc-simcore/blob/04af546b173d7a1c4201367f46d82657ab896d7a/services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/dask_scheduler.py#LL176C40-L176C40
• @sanderegg: Why would you delete the logs of a failing run? Am I misinterpreting something? :-)

Related issue/s

• fixes Flaky tests/public-api/test_solvers_jobs_api.py::test_run_job[FAILED] #3569

How to test

cd tests/public-api
make install-dev
pytest -vv test_solvers_jobs_api.py

[codecov]

Codecov Report

Merging #4205 (d507c0c) into master (c4bb1ef) will increase coverage by 7.2%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master   #4205     +/-   ##
========================================
+ Coverage    73.1%   80.3%   +7.2%     
========================================
  Files         838     952    +114     
  Lines       35246   41354   +6108     
  Branches      953     953             
========================================
+ Hits        25766   33213   +7447     
+ Misses       9276    7924   -1352     
- Partials      204     217     +13     

Flag	Coverage Δ
integrationtests	68.6% <100.0%> (+8.5%)	⬆️
unittests	77.3% <66.6%> (-3.2%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...k/src/simcore_sdk/node_ports_common/filemanager.py	81.6% <100.0%> (+54.9%)	⬆️
...core_service_api_server/api/routes/solvers_jobs.py	60.1% <100.0%> (+1.3%)	⬆️

... and 239 files with indirect coverage changes

[sanderegg]

ok cool. and let's check this question tomorrow.

[GitHK]

👍

[codeclimate]

Code Climate has analyzed commit d507c0c and detected 0 issues on this pull request.

View more on Code Climate.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication