Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: SarValidation test #4193

Merged
merged 10 commits into from
May 5, 2023
Merged

e2e: SarValidation test #4193

merged 10 commits into from
May 5, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented May 4, 2023 •
edited
Loading

What do these changes do?

Adds an e2e Sar Validation test:

  • Instantiate the template as Guest
  • Make sure the service starts
  • Generate training data
    • Get training data
    • Get distribution image
  • Export training data

e2e_SAR

@odeimaiz odeimaiz added the e2e Bugs found by or related to the end-2-end testing label May 4, 2023
@odeimaiz odeimaiz self-assigned this May 4, 2023
@odeimaiz odeimaiz added this to the Pastel de Nata milestone May 5, 2023
@odeimaiz odeimaiz marked this pull request as ready for review May 5, 2023 09:21
@odeimaiz odeimaiz enabled auto-merge (squash) May 5, 2023 09:21
@odeimaiz odeimaiz changed the title WIP: e2e: SarValidation test e2e: SarValidation test May 5, 2023
@codeclimate
Copy link

codeclimate bot commented May 5, 2023

Code Climate has analyzed commit b7db8b4 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

GitHK
GitHK reviewed May 5, 2023
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I got this, the test only partially tests the SarValidation service. Does not test all of its features.
Will it be extended in the future to do so? Is there a reason to do so?

@odeimaiz
Copy link
Member Author

odeimaiz commented May 5, 2023

If I got this, the test only partially tests the SarValidation service. Does not test all of its features. Will it be extended in the future to do so? Is there a reason to do so?

Enough for now

GitHK
GitHK approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz merged commit bb3ae15 into ITISFoundation:master May 5, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2023
Closed
15 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
Closed
24 tasks
@odeimaiz odeimaiz deleted the e2e/sar-test branch August 20, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov approved these changes

@GitHK GitHK GitHK approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg

@SCA-ZMT SCA-ZMT Awaiting requested review from SCA-ZMT

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11

@mguidon mguidon Awaiting requested review from mguidon

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@odeimaiz odeimaiz

Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Milestone
Pastel de Nata
Development

Successfully merging this pull request may close these issues.
3 participants
@odeimaiz @GitHK @pcrespov