🐛 Flaky integration tests relying on migration as a service #4175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4175 +/- ##
========================================
+ Coverage 80.3% 81.4% +1.1%
========================================
Files 934 957 +23
Lines 40956 41439 +483
Branches 906 952 +46
========================================
+ Hits 32911 33768 +857
+ Misses 7853 7468 -385
- Partials 192 203 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
sanderegg
approved these changes
Apr 27, 2023
matusdrobuliak66
approved these changes
Apr 27, 2023
…-waits-for-migration-service
…b.com:GitHK/osparc-simcore-forked into pr-osparc-fixture-waits-for-migration-service
|
Code Climate has analyzed commit ddf7751 and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Makes
migrated_pg_tables_contextto wait for themigrationservice to have finished his migration before proceeding.This impacted all tests requiring a Postgres database and also requesting the
migrationservice in thepytest_simcore_core_services_selection.Tests failed because they usually ran in parallel. This is more evident when the load on the CI is bigger causing delays. Errors such as "field already exists" were showing up in the logs.
Related issue/s
How to test
DevOps Checklist