Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "♻️ Volumes keep track if the data requires saving 🚨 (#3974)" #4139

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Apr 20, 2023

What do these changes do?

This reverts commit 5b9e9bc.

The majority of services (for examplejupyter-math) will run at some point an ownership change of all the volumes. They also remove group permissions to write to the file.
This also affects the .agent file and makes it so that the dynamic-sidecar cannot make any changes to the file.

A solution would have been using immutable files, but an issue with docker blocks us from doing so moby/moby#45177

Related issue/s

How to test

DevOps Checklist

@codeclimate
Copy link

codeclimate bot commented Apr 20, 2023

Code Climate has analyzed commit 816cc0a and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #4139 (816cc0a) into master (5b9e9bc) will increase coverage by 0.6%.
The diff coverage is 91.3%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4139     +/-   ##
========================================
+ Coverage    85.5%   86.1%   +0.6%     
========================================
  Files         959     880     -79     
  Lines       41540   39939   -1601     
  Branches      966     831    -135     
========================================
- Hits        35527   34411   -1116     
+ Misses       5795    5337    -458     
+ Partials      218     191     -27     
Flag Coverage Δ
integrationtests 66.6% <100.0%> (+<0.1%) ⬆️
unittests 82.9% <91.3%> (+0.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/agent/src/simcore_service_agent/core/settings.py 93.9% <ø> (-0.2%) ⬇️
...service_director_v2/api/routes/dynamic_services.py 89.4% <ø> (ø)
...ice_director_v2/models/domains/dynamic_services.py 100.0% <ø> (ø)
...r_v2/modules/dynamic_sidecar/api_client/_public.py 92.3% <ø> (-0.3%) ⬇️
...tor_v2/modules/dynamic_sidecar/api_client/_thin.py 100.0% <ø> (ø)
...ector_v2/modules/dynamic_sidecar/scheduler/_abc.py 100.0% <ø> (ø)
...s/dynamic_sidecar/scheduler/_core/_events_utils.py 91.5% <ø> (-0.4%) ⬇️
...ules/dynamic_sidecar/scheduler/_core/_scheduler.py 78.7% <ø> (ø)
...ctor_v2/modules/dynamic_sidecar/scheduler/_task.py 94.2% <ø> (ø)
...ice_webserver/director_v2_core_dynamic_services.py 70.1% <ø> (ø)
... and 8 more

... and 78 files with indirect coverage changes

@GitHK GitHK marked this pull request as ready for review April 20, 2023 07:59
@GitHK GitHK merged commit 9ef30c9 into ITISFoundation:master Apr 20, 2023
@GitHK GitHK deleted the pr-osparc-revert-docker-volume-with-state branch April 20, 2023 08:24
@GitHK GitHK added this to the Jelly Beans milestone Apr 26, 2023
@GitHK GitHK self-assigned this Apr 26, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants