-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨🐛Dask-gateway: disable adaptive cluster #4137
✨🐛Dask-gateway: disable adaptive cluster #4137
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4137 +/- ##
=========================================
- Coverage 85.0% 71.4% -13.6%
=========================================
Files 954 399 -555
Lines 41294 20564 -20730
Branches 946 174 -772
=========================================
- Hits 35110 14696 -20414
+ Misses 5967 5819 -148
+ Partials 217 49 -168
Flags with carried forward coverage won't be shown. Click here to find out more.
|
a2aa4ed
to
ed7ba87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
services/director-v2/src/simcore_service_director_v2/utils/dask.py
Outdated
Show resolved
Hide resolved
66eb215
to
6d14543
Compare
01e672b
to
f904e94
Compare
be65c13
to
290e41a
Compare
Code Climate has analyzed commit 290e41a and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Since cluster adaptive scaling seems to generate a lot of issues when running thousands of jobs this is now disabled.
Therefore the cluster is scaled to a hard-coded huge number (10'000 workers), which should be enough for the time being.
Bonus: some mypy fixes
Related issue/s
How to test
DevOps Checklist