Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨🐛Dask-gateway: disable adaptive cluster #4137

Merged
merged 6 commits into from
Apr 24, 2023

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Apr 18, 2023

What do these changes do?

Since cluster adaptive scaling seems to generate a lot of issues when running thousands of jobs this is now disabled.
Therefore the cluster is scaled to a hard-coded huge number (10'000 workers), which should be enough for the time being.

Bonus: some mypy fixes

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added the a:dask-service Any of the dask services: dask-scheduler/sidecar or worker label Apr 18, 2023
@sanderegg sanderegg added this to the Jelly Beans milestone Apr 18, 2023
@sanderegg sanderegg self-assigned this Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #4137 (be65c13) into master (12763d6) will decrease coverage by 13.6%.
The diff coverage is 100.0%.

❗ Current head be65c13 differs from pull request most recent head 290e41a. Consider uploading reports for the commit 290e41a to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4137      +/-   ##
=========================================
- Coverage    85.0%   71.4%   -13.6%     
=========================================
  Files         954     399     -555     
  Lines       41294   20564   -20730     
  Branches      946     174     -772     
=========================================
- Hits        35110   14696   -20414     
+ Misses       5967    5819     -148     
+ Partials      217      49     -168     
Flag Coverage Δ
integrationtests 62.2% <78.5%> (-4.8%) ⬇️
unittests 86.3% <95.2%> (+4.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rector_v2/modules/comp_scheduler/dask_scheduler.py 88.4% <ø> (ø)
...rector_v2/modules/comp_scheduler/base_scheduler.py 91.9% <100.0%> (-0.1%) ⬇️
...vice_director_v2/modules/comp_scheduler/factory.py 100.0% <100.0%> (ø)
...simcore_service_director_v2/modules/dask_client.py 93.4% <100.0%> (+0.1%) ⬆️
...r-v2/src/simcore_service_director_v2/utils/dask.py 90.1% <100.0%> (+0.5%) ⬆️
...ore_service_director_v2/utils/dask_client_utils.py 87.6% <100.0%> (+0.1%) ⬆️
...src/simcore_service_director_v2/utils/scheduler.py 100.0% <100.0%> (ø)

... and 730 files with indirect coverage changes

@sanderegg sanderegg force-pushed the dask/remove_auto_adapt branch from a2aa4ed to ed7ba87 Compare April 19, 2023 06:29
@sanderegg sanderegg marked this pull request as ready for review April 19, 2023 06:29
@sanderegg sanderegg requested a review from mguidon April 19, 2023 06:29
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg sanderegg force-pushed the dask/remove_auto_adapt branch from be65c13 to 290e41a Compare April 24, 2023 07:17
@codeclimate
Copy link

codeclimate bot commented Apr 24, 2023

Code Climate has analyzed commit 290e41a and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Apr 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg merged commit 7a2ba22 into ITISFoundation:master Apr 24, 2023
@sanderegg sanderegg deleted the dask/remove_auto_adapt branch April 24, 2023 08:28
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dask-service Any of the dask services: dask-scheduler/sidecar or worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detected problems in computational backend
3 participants