Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix minor bugs in project plugin and director #4123

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Apr 16, 2023

What do these changes do?

Fixes the following bugs detected by sonar cloud:

Related issue/s

How to test

In place

@pcrespov pcrespov self-assigned this Apr 16, 2023
@pcrespov pcrespov added t:maintenance Some planned maintenance work changelog:🐛bugfix labels Apr 16, 2023
@pcrespov pcrespov added this to the Jelly Beans milestone Apr 16, 2023
@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #4123 (49e3ea6) into master (d59ba4d) will increase coverage by 3.0%.
The diff coverage is 81.8%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4123     +/-   ##
========================================
+ Coverage    83.6%   86.7%   +3.0%     
========================================
  Files         957     801    -156     
  Lines       41452   37129   -4323     
  Branches      954     461    -493     
========================================
- Hits        34672   32205   -2467     
+ Misses       6564    4815   -1749     
+ Partials      216     109    -107     
Flag Coverage Δ
integrationtests 67.3% <0.0%> (+14.3%) ⬆️
unittests 83.2% <81.8%> (+1.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/dask_task_models_library/container_tasks/io.py 100.0% <ø> (ø)
...dels-library/src/models_library/rest_pagination.py 96.5% <ø> (ø)
...ages/models-library/src/models_library/services.py 93.6% <ø> (ø)
...es/director/src/simcore_service_director/config.py 100.0% <ø> (ø)
...invitations/src/simcore_service_invitations/cli.py 93.4% <ø> (ø)
...mcore_service_webserver/projects/projects_utils.py 87.7% <ø> (+4.2%) ⬆️
.../src/simcore_service_webserver/statics_settings.py 80.0% <ø> (ø)
.../director/src/simcore_service_director/producer.py 67.2% <75.0%> (-0.4%) ⬇️
...talog/src/simcore_service_catalog/core/settings.py 100.0% <100.0%> (ø)
...-v2/src/simcore_service_director_v2/cli/_client.py 100.0% <100.0%> (ø)
... and 1 more

... and 198 files with indirect coverage changes

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering about that change in the director... passing tasks. what comes back? is it not modified?

services/director/src/simcore_service_director/producer.py Outdated Show resolved Hide resolved
@pcrespov pcrespov force-pushed the fix/sonarcld-bugs-project-n-director branch from bd58035 to 9825da9 Compare April 17, 2023 08:40
@pcrespov pcrespov enabled auto-merge (squash) April 17, 2023 08:47
@pcrespov pcrespov requested a review from odeimaiz as a code owner April 17, 2023 18:31
@pcrespov pcrespov force-pushed the fix/sonarcld-bugs-project-n-director branch from 6d05378 to 245de22 Compare April 25, 2023 14:07
@pcrespov pcrespov force-pushed the fix/sonarcld-bugs-project-n-director branch from 8e49d7d to b8a8480 Compare April 28, 2023 13:17
@codeclimate
Copy link

codeclimate bot commented May 2, 2023

Code Climate has analyzed commit 49e3ea6 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov disabled auto-merge May 2, 2023 16:18
@pcrespov pcrespov merged commit 95c2073 into ITISFoundation:master May 2, 2023
@pcrespov pcrespov deleted the fix/sonarcld-bugs-project-n-director branch May 2, 2023 16:18
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bugs reported by sonarcloud
4 participants