♻️ project CRUD routes: updates OAS and model schemas (part 1) #4064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #4064 +/- ##
========================================
- Coverage 85.4% 85.4% -0.1%
========================================
Files 952 954 +2
Lines 41350 41294 -56
Branches 962 946 -16
========================================
- Hits 35350 35283 -67
- Misses 5782 5794 +12
+ Partials 218 217 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pcrespov
force-pushed
the
is4059/project-patch-part1
branch
from
82871a6 to
8b6e9e1
Compare
pcrespov
force-pushed
the
is4059/project-patch-part1
branch
3 times, most recently
from
11f1632 to
f4c146e
Compare
pcrespov
force-pushed
the
is4059/project-patch-part1
branch
from
61a4db3 to
92c2a1b
Compare
pcrespov
changed the title
sanderegg
approved these changes
Apr 13, 2023
pcrespov
force-pushed
the
is4059/project-patch-part1
branch
from
2707818 to
8a637dd
Compare
|
Code Climate has analyzed commit 6b105be and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR reviews the specs and implementation of CRUD operations on the
projectresource. The OAS now exposes a PATCH as well and all the schemas have been reviewed:This PR is very verbose and therefore, for the sake of clarity, is the first of many parts.
Highlights
projectand creates multiple pydantic models for projects inprojects/_rest_schemas.pytest_projects__rest_schemas.pywhere new models are tested against data captured from real fe-be communications.api/specs/webserver/scripts/openapi_projects_crud.pyPATCH /project/*interface (Implementation will follow in next PR)project_crud_handlersprojects/_utils*.pyPOST /projectsvalidate now request body with new modelsapi/schemasfilesmypyin ⬆️Maintenance: update mypy to 1.2.0 #4108 resurfaced new issuesRelated issue/s
How to test
cd services/web/server make install-dev pytest -vv tests/unit/isolated/test_project*.py