✨ Link to dispatch study with file-only and 🐛 fixes download link

[pcrespov]

What do these changes do?

• ✨ view links can now dispatch a new study with a single file-picker that can pull data from the portal (or any other download link)
  • limited to registered users (i.e. user, tester or admin but not guests)
  • one file at a time
• ♻️ refactors simcore_service_webserver/studies_dispatcher plugin
  • better error definitions and handling (see _errors.py and _constants.py)
  • ⚠️ adds env-vars
    • STUDIES_DEFAULT_SERVICE_THUMBNAIL, STUDIES_DEFAULT_FILE_THUMBNAIL for default thumbnails
    • STUDIES_MAX_FILE_SIZE_ALLOWED max file size
    • For the moment we will use defaults in the code i.e. no changes in osparc-ops required!
• 🐛 Fixes download_link decoding that causes Portal "viewers" sometimes don't get the file in the FilePicker #3951

Related issue/s

• resolves M7 Pulling files from the Portal osparc-issues#682 (backend side)
• fixes Portal "viewers" sometimes don't get the file in the FilePicker #3951

How to test

make devenv
source .venv/bin/activate
cd services/web/server
make install-dev
pytest -vv tests/unit/**/test_*dispatch*.py

Manual exploratory testing

make build
make up-devel

Login and try the following links to dispatch a study with ...

• file and service : http://127.0.0.1:9081/view?file_type=IPYNB&viewer_key=simcore/services/dynamic/jupyter-octave-python-math&viewer_version=1.0.0&file_size=300&file_name=sample.ipynb&download_link=https://raw.githubusercontent.com/pcrespov/osparc-sample-studies/master/files%2520samples/sample.ipynb
• only service: http://127.0.0.1:9081/view?viewer_key=simcore/services/dynamic/jupyter-octave-python-math&viewer_version=1.0.0
• only file: http://127.0.0.1:9081/view?file_type=IPYNB&file_size=300&file_name=sample.ipynb&download_link=https://raw.githubusercontent.com/pcrespov/osparc-sample-studies/master/files%2520samples/sample.ipynb

[codecov]

Codecov Report

Merging #4043 (4fb47ca) into master (5050682) will decrease coverage by 0.6%.
The diff coverage is 81.5%.

@@           Coverage Diff            @@
##           master   #4043     +/-   ##
========================================
- Coverage    85.5%   84.9%   -0.6%     
========================================
  Files         957     885     -72     
  Lines       41448   40064   -1384     
  Branches      954     824    -130     
========================================
- Hits        35467   34044   -1423     
- Misses       5765    5830     +65     
+ Partials      216     190     -26     

Flag	Coverage Δ
integrationtests	62.0% <52.5%> (-5.4%)	⬇️
unittests	82.9% <81.5%> (+0.5%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...c/models_library/utils/pydantic_tools_extension.py	0.0% <0.0%> (ø)
...rary/src/servicelib/aiohttp/requests_validation.py	86.3% <63.6%> (-3.9%)	⬇️
...core_service_webserver/studies_dispatcher/_core.py	77.7% <63.6%> (-2.6%)	⬇️
...es/web/server/src/simcore_service_webserver/cli.py	47.0% <66.6%> (ø)
...ce_webserver/studies_dispatcher/_studies_access.py	90.5% <70.0%> (ø)
...ebserver/studies_dispatcher/_redirects_handlers.py	85.7% <85.7%> (ø)
..._service_webserver/studies_dispatcher/_projects.py	93.8% <86.4%> (+0.4%)	⬆️
...e_service_webserver/studies_dispatcher/_catalog.py	95.6% <87.5%> (+0.2%)	⬆️
...ore_service_webserver/studies_dispatcher/_users.py	85.0% <87.5%> (+0.6%)	⬆️
...ice_webserver/studies_dispatcher/_rest_handlers.py	91.5% <91.6%> (ø)
... and 5 more

... and 111 files with indirect coverage changes

[mrnicegyu11]

Didnt check everything in Detail, Just some comments. Thanks a lot!

[GitHK]

Nice, please have a look at some doubts

[odeimaiz]

👍

[matusdrobuliak66]

👍

[codeclimate]

Code Climate has analyzed commit 4fb47ca and detected 0 issues on this pull request.

View more on Code Climate.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[mguidon]

We need another iteration. Dominic will provide an nicer looking icon and we have to adapt the text and explain who can get an account (on the resources&tool page as well as on the panda page). Also, synchronize language with the Open in osparc button
@ignapas @elisabettai This should be done in the QA period until Friday, July 07.

[ignapas]

We need another iteration. Dominic will provide an nicer looking icon and we have to adapt the text and explain who can get an account (on the resources&tool page as well as on the panda page). Also, synchronize language with the Open in osparc button @ignapas @elisabettai This should be done in the QA period until Friday, July 07.

Changes were implemented and ready to test in staging