-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Is812/email case insensitive v2 (⚠️ devops) 🚨 #3998
🐛 Is812/email case insensitive v2 (⚠️ devops) 🚨 #3998
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3998 +/- ##
=========================================
+ Coverage 77.2% 85.2% +8.0%
=========================================
Files 730 944 +214
Lines 31552 40887 +9335
Branches 539 849 +310
=========================================
+ Hits 24359 34855 +10496
+ Misses 7055 5810 -1245
- Partials 138 222 +84
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…buliak66/osparc-simcore into is812/email-case-insensitive-v2
services/invitations/src/simcore_service_invitations/api/_dependencies.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/login/handlers_registration.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/login/handlers_registration.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/studies_dispatcher/_users.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool. Maybe have a look at the links I put in the comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good. some minor things
services/web/server/src/simcore_service_webserver/groups_handlers.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/studies_dispatcher/_studies_access.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
- Just update the description of the PR (I think the requirements section does not apply, right?)
- And do not forget to fix the codesmell by sonarcloud please
Code Climate has analyzed commit 7b30729 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
🐛 bug These changes make emails' case insensitive.
⬆️ Increased 1.0.0 ---> 1.0.1 version of Invitation service
Highlights on updated libraries (only updated libraries are included)
(pydantic downgrade 🔥 currently there is a global constrain this should be fixed by #3905)
Related issue/s
How to test
Checklist