Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Is812/email case insensitive v2 (⚠️ devops) 🚨 #3998

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Mar 20, 2023

What do these changes do?

🐛 bug These changes make emails' case insensitive.

  • Now we will store all emails in the database in lower case, and when a user wants to authenticate with upper case, or wants to add user to the group with upper case (as is mentioned in the issue below) it will be possible.
  • This is a total redo of the previous pull request 🐛 Is812/email case insensitive #3953 (that I have closed) after discussion to change the emails at the point of ingress of the application.

⬆️ Increased 1.0.0 ---> 1.0.1 version of Invitation service

  • introduced models-library dependency
  • (⚠️ devops) 🚨 We need to redeploy the invitation service

Highlights on updated libraries (only updated libraries are included)

# name before after upgrade count packages
1 attrs 22.2.0 21.4.0 minor 1 invitations🧪
2 pydantic 1.10.4 1.10.2 🔥 downgrade 1 invitations⬆️

(pydantic downgrade 🔥 currently there is a global constrain this should be fixed by #3905)

Related issue/s

How to test

Checklist

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #3998 (7b30729) into master (95ef4e3) will increase coverage by 8.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3998      +/-   ##
=========================================
+ Coverage    77.2%   85.2%    +8.0%     
=========================================
  Files         730     944     +214     
  Lines       31552   40887    +9335     
  Branches      539     849     +310     
=========================================
+ Hits        24359   34855   +10496     
+ Misses       7055    5810    -1245     
- Partials      138     222      +84     
Flag Coverage Δ
integrationtests 66.8% <89.1%> (+6.1%) ⬆️
unittests 82.1% <100.0%> (+7.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/models-library/src/models_library/emails.py 100.0% <100.0%> (ø)
...ages/models-library/src/models_library/projects.py 95.5% <100.0%> (+<0.1%) ⬆️
...ages/models-library/src/models_library/services.py 93.1% <100.0%> (+<0.1%) ⬆️
...core_service_api_server/models/schemas/profiles.py 100.0% <100.0%> (ø)
.../src/simcore_service_api_server/modules/catalog.py 62.6% <100.0%> (+0.5%) ⬆️
.../simcore_service_catalog/db/repositories/groups.py 59.4% <100.0%> (ø)
...g/src/simcore_service_catalog/models/domain/dag.py 100.0% <100.0%> (ø)
...simcore_service_catalog/models/schemas/services.py 100.0% <100.0%> (ø)
...c/simcore_service_invitations/api/_dependencies.py 100.0% <100.0%> (ø)
...invitations/src/simcore_service_invitations/cli.py 93.4% <100.0%> (+0.1%) ⬆️
... and 16 more

... and 302 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 self-assigned this Mar 20, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Mithril milestone Mar 20, 2023
@matusdrobuliak66 matusdrobuliak66 added changelog:🐛bugfix a:webserver issue related to the webserver service a:catalog catalog service a:apiserver api-server service a:invitations invitations service labels Mar 20, 2023
@matusdrobuliak66 matusdrobuliak66 changed the title Is812/email case insensitive v2 🐛 Is812/email case insensitive v2 (⚠️ devops) 🚨 Mar 20, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review March 20, 2023 18:10
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Maybe have a look at the links I put in the comment

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good. some minor things

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

  • Just update the description of the PR (I think the requirements section does not apply, right?)
  • And do not forget to fix the codesmell by sonarcloud please

@codeclimate
Copy link

codeclimate bot commented Mar 22, 2023

Code Climate has analyzed commit 7b30729 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@matusdrobuliak66 matusdrobuliak66 merged commit 32fdc23 into ITISFoundation:master Mar 22, 2023
@pcrespov pcrespov mentioned this pull request Mar 23, 2023
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:apiserver api-server service a:catalog catalog service a:invitations invitations service a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e-mails in simcore should be case-insensitives
4 participants