Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bugfix: Let users make Services Public #3997

Merged
merged 5 commits into from
Mar 20, 2023
Merged

🐛 Bugfix: Let users make Services Public #3997

merged 5 commits into from
Mar 20, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Mar 20, 2023 •
edited
Loading

What do these changes do?

Since the last organization/members refactoring in the frontend, services can't be shared with Everyone. This PR enables again the feature.

ShareWithEveryone

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz self-assigned this Mar 20, 2023
@odeimaiz odeimaiz added this to the Mithril milestone Mar 20, 2023
@odeimaiz odeimaiz marked this pull request as ready for review March 20, 2023 14:32
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🐛bugfix labels Mar 20, 2023
elisabettai
elisabettai approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the super-speedy fix!

pcrespov
pcrespov reviewed Mar 20, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our last conversation, I thought you did not recommend to offer this functionality to the user. If i recall well you were even reluctant to offer this feature to admin or testers! What made you change your midn?

@odeimaiz
Copy link
Member Author

odeimaiz commented Mar 20, 2023 •
edited
Loading

Based on our last conversation, I thought you did not recommend to offer this functionality to the user. If i recall well you were even reluctant to offer this feature to admin or testers! What made you change your midn?

Services can now (again) be shared by any user, studies/templates only by testers. Our last conversation was about publishing templates to even anonymous users...

@odeimaiz odeimaiz enabled auto-merge (squash) March 20, 2023 14:45
@pcrespov
Copy link
Member

Based on our last conversation, I thought you did not recommend to offer this functionality to the user. If i recall well you were even reluctant to offer this feature to admin or testers! What made you change your midn?

Services can now (again) be shared by any user, studies/templates only by testers. Our last conversation was about publishing templates to even anonymous users...

Thanks for the clarification. Actually it aligns nicely with what I am doing now for the jlab.

@codeclimate
Copy link

codeclimate bot commented Mar 20, 2023

Code Climate has analyzed commit d2d6a36 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Mar 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odeimaiz odeimaiz merged commit ef19c77 into ITISFoundation:master Mar 20, 2023
This was referenced Mar 22, 2023
Closed
Closed
@odeimaiz odeimaiz deleted the feature/make-service-public branch August 20, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@sanderegg sanderegg sanderegg approved these changes

@elisabettai elisabettai elisabettai approved these changes

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@GitHK GitHK Awaiting requested review from GitHK

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
Mithril
Development

Successfully merging this pull request may close these issues.
5 participants
@odeimaiz @pcrespov @mrnicegyu11 @elisabettai @sanderegg