🚑️ Fix GC error while trying to close service

[GitHK]

What do these changes do?

GC was wrongly fetching the project_id, it is now recovered from the intended data structure. I have no idea why I did that 🤷‍♂️

ERROR: [2023-03-17 08:34:35,601/MainProcess] [simcore_service_webserver.garbage_collector_core:_remove_single_orphaned_service(166)]  -  Exception: '6c2bca80-75f6-56bd-b169-7386e6e0ce21'
Traceback (most recent call last):
  File "/home/scu/.venv/lib/python3.9/site-packages/servicelib/logging_utils.py", line 160, in log_decorator_wrapper
    value = await func(*args, **kwargs)
  File "/home/scu/.venv/lib/python3.9/site-packages/simcore_service_webserver/garbage_collector_core.py", line 365, in _remove_single_orphaned_service
    project_uuid = currently_opened_projects_node_ids[service_uuid]
KeyError: '6c2bca80-75f6-56bd-b169-7386e6e0ce21'

Related issue/s

• fixes Garbage collector not working on aws-prod #3975
• M1-12 Maintenance and DevOps osparc-issues#675

How to test

Checklist

• Unit tests for the changes exist

[codecov]

Codecov Report

Merging #3985 (58c67ba) into master (4aa9a3d) will decrease coverage by 2.5%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           master   #3985      +/-   ##
=========================================
- Coverage    85.2%   82.7%    -2.5%     
=========================================
  Files         943     392     -551     
  Lines       40680   20158   -20522     
  Branches      848     137     -711     
=========================================
- Hits        34665   16676   -17989     
+ Misses       5792    3433    -2359     
+ Partials      223      49     -174     

Flag	Coverage Δ
integrationtests	66.7% <50.0%> (-0.1%)	⬇️
unittests	83.3% <100.0%> (+1.3%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...imcore_service_webserver/garbage_collector_core.py	82.4% <100.0%> (+11.1%)	⬆️

... and 639 files with indirect coverage changes

[mrnicegyu11]

Thanks a lot and good luck!

Can we have a regression alert as well, some log-line to check if it happens again, or does this not apply here since you changed the code?

[GitHK]

Thanks a lot and good luck!

Can we have a regression alert as well, some log-line to check if it happens again, or does this not apply here since you changed the code?

No need for an alert here. If a different error occurs, it will display a useful traceback now.

[sanderegg]

I think you massively increased the logs in the GC right? maybe care to reduce them if this is the fix.
Also please check my comments.

[codeclimate]

Code Climate has analyzed commit 58c67ba and detected 0 issues on this pull request.

View more on Code Climate.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.1% Duplication