Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix: Thumbnail width on Large Card #3973

Merged
merged 4 commits into from
Mar 15, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Mar 15, 2023

What do these changes do?

If the the aspect ratio of a thumbnail was too wide, it could trigger an infinite re-render of the entire Large Card (triggering also some unnecessary calls to the backend) and an annoying scrollbar that could hide key buttons.

This zusammenzuführen standardizes all the Large Cards (Study, Service and Merged) and limits the max width of the thumbnail.

Before:
Before

After:
After

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz self-assigned this Mar 15, 2023
@odeimaiz odeimaiz marked this pull request as ready for review March 15, 2023 11:32
@odeimaiz odeimaiz changed the title WIP 🐛 Fix: Thumbnail width on Large Card 🐛 Fix: Thumbnail width on Large Card Mar 15, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 15, 2023

Code Climate has analyzed commit 916667d and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odeimaiz odeimaiz added this to the Mithril milestone Mar 15, 2023
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🐛bugfix labels Mar 15, 2023
@odeimaiz odeimaiz enabled auto-merge (squash) March 15, 2023 12:29
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice zusammenzuführen

Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻
The flashy thumbnail was kind of cool, though. 😉

@odeimaiz odeimaiz merged commit 5878e8f into ITISFoundation:master Mar 15, 2023
@odeimaiz odeimaiz deleted the fix/thumbail-max-width branch March 15, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants