-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix: Thumbnail width on Large Card #3973
🐛 Fix: Thumbnail width on Large Card #3973
Conversation
Code Climate has analyzed commit 916667d and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
services/static-webserver/client/source/class/osparc/MaintenanceTracker.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice zusammenzuführen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
The flashy thumbnail was kind of cool, though. 😉
What do these changes do?
If the the aspect ratio of a thumbnail was too wide, it could trigger an infinite re-render of the entire Large Card (triggering also some unnecessary calls to the backend) and an annoying scrollbar that could hide key buttons.
This zusammenzuführen standardizes all the Large Cards (Study, Service and Merged) and limits the max width of the thumbnail.
Before:
After:
Related issue/s
How to test
Checklist