♻️Autoscaling: set default termination time of EC2 instance to 1 minute #3970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
changelog:♻️refactor
a:autoscaling
|
Code Climate has analyzed commit db563e5 and detected 0 issues on this pull request. View more on Code Climate. |
sanderegg
requested review from
mrnicegyu11,
GitHK,
matusdrobuliak66 and
odeimaiz
pcrespov
approved these changes
Mar 14, 2023
mrnicegyu11
approved these changes
Mar 14, 2023
matusdrobuliak66
approved these changes
Mar 14, 2023
Codecov Report
@@ Coverage Diff @@
## master #3970 +/- ##
=========================================
- Coverage 83.0% 68.1% -14.9%
=========================================
Files 943 413 -530
Lines 40665 21128 -19537
Branches 848 137 -711
=========================================
- Hits 33764 14407 -19357
+ Misses 6691 6672 -19
+ Partials 210 49 -161
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Kudos, SonarCloud Quality Gate passed!
|
GitHK
approved these changes
Mar 14, 2023
sanderegg
deleted the
autoscaling/terminate_ec2_instances_after_1_minute
branch
This was referenced Mar 20, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
fixes ITISFoundation/osparc-issues#657
as explained there:
https://aws.amazon.com/ec2/pricing/on-demand/
The price of EC2 instances is billed by the second. therefore the default for terminating a node is changed from 55 minutes to 1 minute.
Related issue/s
How to test
Checklist