🎨 Frontend: Improve UX for "Download of Study Data" #3963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
a:frontend
odeimaiz
changed the title
odeimaiz
changed the title
odeimaiz
requested review from
sanderegg,
pcrespov,
mrnicegyu11,
elisabettai,
GitHK and
mguidon
|
Kudos, SonarCloud Quality Gate passed!
|
|
Code Climate has analyzed commit 2e6b577 and detected 0 issues on this pull request. View more on Code Climate. |
17 tasks
|
Hi @odeimaiz, I'm getting this dialog when clicking on Download: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR changes the way files are downloaded in the File Browser window.
Until now, we were downloading files using XMLHttpRequest and the given (presigned) URL. This meant that first the response had to be loaded, then convert it into the file blob and finally download it.
Now, we simply create a virtual HTML
<a>tag, make it point to the given (presigned) URL and virtually click it, which directly starts the download process.Related issue/s
closes ITISFoundation/osparc-issues#899
How to test
Checklist