✨ Error pages when published studies dispatcher fails, access rights fixes and plugin refactoring

[pcrespov]

What do these changes do?

To publish a study it needs to:

1. Be a template
2. Share with everybody
3. published fiend in the database must be checked

Currently any published study can be accessed via a link with path /study/{project_id}. That link will copy and open the study even if the user is not logged it. If this request fails it will now display an error page with details.

This PR provides:

• ✨ Improves error handling and reporting. Redirects to an error page created in the front-end (previously was just raw text)
• ✨ Guest users (i.e. the ones that are not registered) use now temp accounts with expiration date
• 🐛 Fixes permission errors while copying data from published template

@odeimaiz some improvements in the FE are necessary for the two first items -> #3987

In addition, this PR

• ♻️ refactors error handling and tests. (follow up in Maintenance: integrate _studies_access.py into studies_dispatcher #3977 )
• 🔨 new action "Python: Remote Attach GC webserver" in the `launch.template.json`` to debug the garbage collection service
• 🐛 small fix in catalog

Related issue/s

• partially resolves jLab: you need to be logged in osparc-issues#829: error handling
• Related to Portal "viewers" sometimes don't get the file in the FilePicker #3951
• Fixes Can't instantiate some ISAN tutorials #3884: fixes permission errors while copying data

How to test

1. Publish a study (follow the definition above to publish a study). browse https://{host}:{port}/studies/{study_uuid} as guest and will open a copy of the study
2. log in. browse https://{host}:{port}/studies/{study_uuid} and will open a copy of the study
3. disable publish flag. browse https://{host}:{port}/studies/{study_uuid} should fail with an error page
4. Enable publish flag and remove everyone access rights. browse https://{host}:{port}/studies/{study_uuid} should fail with an error page
5. Enable publish flag and remove everyone access rights, then browse https://{host}:{port}/studies/{study_uuid} should fail with an error page

cd services/web/server
make install-dev
pytest -vv tests/unit/with_dbs/01/test_studies_dispatcher_studies_access.py

Checklist

• make version-*
• Unit tests for the changes exist
• Runs in the swarm

[codecov]

Codecov Report

Merging #3962 (77210b0) into master (77c36e0) will decrease coverage by 2.3%.
The diff coverage is 92.9%.

@@            Coverage Diff            @@
##           master   #3962      +/-   ##
=========================================
- Coverage    85.6%   83.4%    -2.3%     
=========================================
  Files         793     429     -364     
  Lines       36675   21960   -14715     
  Branches      842     137     -705     
=========================================
- Hits        31418   18316   -13102     
+ Misses       5034    3595    -1439     
+ Partials      223      49     -174     

Flag	Coverage Δ
integrationtests	66.7% <57.1%> (-0.1%)	⬇️
unittests	84.3% <92.9%> (+2.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
..._service_webserver/studies_dispatcher/_projects.py	90.0% <ø> (ø)
...ce_webserver/studies_dispatcher/_studies_access.py	90.9% <87.2%> (+4.5%)	⬆️
..._service_webserver/projects/projects_exceptions.py	93.6% <91.6%> (-1.0%)	⬇️
...re_service_webserver/projects/projects_db_utils.py	97.0% <97.3%> (-0.4%)	⬇️
.../storage/src/simcore_service_storage/exceptions.py	100.0% <100.0%> (ø)
...e_service_webserver/login/handlers_registration.py	90.8% <100.0%> (ø)
.../simcore_service_webserver/projects/projects_db.py	96.4% <100.0%> (+<0.1%)	⬆️
...service_webserver/studies_dispatcher/_constants.py	100.0% <100.0%> (ø)
...ore_service_webserver/studies_dispatcher/_users.py	84.1% <100.0%> (+1.0%)	⬆️
...e_service_webserver/studies_dispatcher/settings.py	100.0% <100.0%> (ø)

... and 453 files with indirect coverage changes

[odeimaiz]

👍

[GitHK]

Some minor things 👍

[sanderegg]

looking good! some small comments. and also be careful with usage of utcnow

[elisabettai]

Thanks @pcrespov for this!
If I understand it well, we are NOT yet blocking "guests" from accessing certain templates, right?
Is it something that will be done soon? EN just asked when we can put online links to templates with Jupyterlabs. They are needed for the SC meeting (=ideally today or tomorrow, when the first documents will be sent to the SC).

Maybe we can workaround by using the temp accounts that you have introduced with this PR? We can make the duration quite short, do avoid any malicious intervention...

[codeclimate]

Code Climate has analyzed commit 77210b0 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication