Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Frontend: Ask for confirmation before demoting an Organization to Viewer #3961

Merged
merged 10 commits into from
Mar 13, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Mar 10, 2023

What do these changes do?

This PR makes the frontend ask for confirmation when a user tries to Demote a Organization's role in a study/template collaboration.

This confirmation can be disabled in the preferences.

DemoteOrgToViewer

Related issue/s

closes ITISFoundation/osparc-issues#901

How to test

Checklist

@odeimaiz odeimaiz self-assigned this Mar 10, 2023
@odeimaiz odeimaiz added this to the Mithril milestone Mar 10, 2023
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Mar 10, 2023
@odeimaiz odeimaiz changed the title confirmDemoteOrgnaization preference Frontend: Ask for confirmation before demoting an Organization to Viewer Mar 10, 2023
@odeimaiz odeimaiz changed the title Frontend: Ask for confirmation before demoting an Organization to Viewer ✨ Frontend: Ask for confirmation before demoting an Organization to Viewer Mar 10, 2023
@odeimaiz odeimaiz marked this pull request as ready for review March 10, 2023 12:36
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I'd change the message to "Demoting to Viewer will remove write access to all the members of the Organization. Are you sure?"
And change the confirmation button string to "Yes" (instead of "Demote").

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codeclimate
Copy link

codeclimate bot commented Mar 13, 2023

Code Climate has analyzed commit 1164c3d and detected 0 issues on this pull request.

View more on Code Climate.

@odeimaiz odeimaiz enabled auto-merge (squash) March 13, 2023 09:05
@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odeimaiz odeimaiz merged commit 37a5cb5 into ITISFoundation:master Mar 13, 2023
@pcrespov pcrespov mentioned this pull request Mar 23, 2023
31 tasks
@odeimaiz odeimaiz deleted the feature/confirm-demote branch August 20, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demoting a full organization might need a danger zone
4 participants