-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Attempt to avoid connection pool running out of connections #3947
🐛 Attempt to avoid connection pool running out of connections #3947
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3947 +/- ##
=========================================
+ Coverage 71.9% 86.2% +14.3%
=========================================
Files 898 126 -772
Lines 38439 6380 -32059
Branches 839 0 -839
=========================================
- Hits 27643 5504 -22139
+ Misses 10588 876 -9712
+ Partials 208 0 -208
Flags with carried forward coverage won't be shown. Click here to find out more.
|
...ices/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/api_client/_base.py
Show resolved
Hide resolved
…rc-simcore-forked into pr-osparc-fix-connection-pool
Code Climate has analyzed commit b75ab69 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds like a plausible solution to the saturation of connections we detected! thx
What do these changes do?
Connections pool slowly fills up and at some point connections run out. This instructs the remote webserver (aka: the sidecar's Uvicorn to close the connection after the request is over).
If this brings no benefits will replace the global client with a per sidecar client.
Related issue/s
How to test
Checklist