Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Using a more proper message type #3936

Merged
merged 6 commits into from
Mar 3, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Mar 2, 2023

What do these changes do?

The message type was nodeProgress, moved to projectProgress.

Related issue/s

How to test

Checklist

@GitHK GitHK self-assigned this Mar 2, 2023
@GitHK GitHK added a:static-webserver static-webserver service changelog:🐛bugfix labels Mar 2, 2023
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #3936 (a97a244) into master (0576631) will decrease coverage by 5.7%.
The diff coverage is 33.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3936      +/-   ##
=========================================
- Coverage    83.5%   77.8%    -5.7%     
=========================================
  Files         934     384     -550     
  Lines       40156   19736   -20420     
  Branches      839     137     -702     
=========================================
- Hits        33535   15359   -18176     
+ Misses       6400    4328    -2072     
+ Partials      221      49     -172     
Flag Coverage Δ
integrationtests 61.6% <33.3%> (-0.1%) ⬇️
unittests 83.4% <33.3%> (+2.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...simcore_service_webserver/computation_subscribe.py 88.7% <0.0%> (-1.5%) ⬇️
...r/src/simcore_service_webserver/socketio/events.py 94.7% <100.0%> (+0.1%) ⬆️
...-v2/src/simcore_service_director_v2/cli/_client.py 0.0% <0.0%> (-100.0%) ⬇️
...v2/src/simcore_service_director_v2/cli/__init__.py 0.0% <0.0%> (-100.0%) ⬇️
...service_director_v2/cli/_close_and_save_service.py 0.0% <0.0%> (-100.0%) ⬇️
...odules/dynamic_sidecar/scheduler/_core2/_errors.py 0.0% <0.0%> (-100.0%) ⬇️
...odules/dynamic_sidecar/scheduler/_core2/_marker.py 0.0% <0.0%> (-100.0%) ⬇️
...odules/dynamic_sidecar/scheduler/_core2/_models.py 0.0% <0.0%> (-100.0%) ⬇️
...dules/dynamic_sidecar/scheduler/_core2/__init__.py 0.0% <0.0%> (-100.0%) ⬇️
...ules/dynamic_sidecar/scheduler/_core2/_workflow.py 0.0% <0.0%> (-100.0%) ⬇️
... and 655 more

@GitHK GitHK marked this pull request as ready for review March 2, 2023 14:34
@GitHK GitHK requested review from pcrespov and sanderegg as code owners March 2, 2023 14:34
@codeclimate
Copy link

codeclimate bot commented Mar 3, 2023

Code Climate has analyzed commit a97a244 and detected 0 issues on this pull request.

View more on Code Climate.

@GitHK GitHK enabled auto-merge (squash) March 3, 2023 07:10
@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@GitHK GitHK merged commit 8d0ffd4 into ITISFoundation:master Mar 3, 2023
@GitHK GitHK deleted the pr-osparc-progress-followup branch March 3, 2023 08:23
@pcrespov pcrespov mentioned this pull request Mar 23, 2023
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:static-webserver static-webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants