✨Autoscaling: have a buffer of machines always ready (episode I) (⚠️ devops)

[sanderegg]

What do these changes do?

• some refactoring
• some bugfixes (issues with timezones, never use utcnow() anymore but now(timezone.utc), getting EC2 instances AND vs OR operation, sending of progress when upscaling)
• adds Name tag on EC2 instances such that lucky people with UI access can see machine names ;) @Surfict
• (⚠️ devops) introduces new ENV EC2_INSTANCES_MACHINES_BUFFER, defaults to 0 when undefined Please currently define to 0

This PR teaches the autoscaling to keep a buffer of machines when upscaling and downscaling BUT not usable until episode II as this will indeed create more machines than necessary in case of load and keep always that number of buffer machines when scaling down but not ensure that EC2_INSTANCES_MACHINES_BUFFER is always present.

Related issue/s

How to test

Checklist

[codecov]

Codecov Report

Merging #3790 (866c343) into master (530b8bb) will increase coverage by 0.6%.
The diff coverage is n/a.

❗ Current head 866c343 differs from pull request most recent head 8ca6f53. Consider uploading reports for the commit 8ca6f53 to get more accurate results

@@           Coverage Diff            @@
##           master   #3790     +/-   ##
========================================
+ Coverage    84.1%   84.8%   +0.6%     
========================================
  Files         897     920     +23     
  Lines       38663   39131    +468     
  Branches      748     793     +45     
========================================
+ Hits        32546   33190    +644     
+ Misses       5918    5731    -187     
- Partials      199     210     +11     

Flag	Coverage Δ
integrationtests	66.7% <0.0%> (-0.1%)	⬇️
unittests	81.9% <0.0%> (+0.8%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...mcore_service_dynamic_sidecar/core/docker_utils.py	75.0% <0.0%> (-3.4%)	⬇️
...imcore_service_webserver/garbage_collector_task.py	83.7% <0.0%> (-2.4%)	⬇️
...imcore_service_webserver/garbage_collector_core.py	61.3% <0.0%> (-1.8%)	⬇️
...mcore_service_webserver/garbage_collector_utils.py	83.3% <0.0%> (-1.3%)	⬇️
...s/dynamic_sidecar/scheduler/_core/_events_utils.py	94.6% <0.0%> (-0.8%)	⬇️
...ervice_dynamic_sidecar/modules/outputs/_manager.py	95.2% <0.0%> (-0.1%)	⬇️
...library/src/servicelib/long_running_tasks/_task.py	95.2% <0.0%> (ø)
...es/settings-library/src/settings_library/rabbit.py	0.0% <0.0%> (ø)
...s/settings-library/src/settings_library/r_clone.py	100.0% <0.0%> (ø)
...settings-library/src/settings_library/utils_cli.py	78.1% <0.0%> (ø)
... and 35 more

[GitHK]

👍

[GitHK]

Nice!

[mrnicegyu11]

Sorry I absolutely do not have time to even quickly read this at this point. just letting you know.

[codeclimate]

Code Climate has analyzed commit 8ca6f53 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication