Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Fixes public-api tests #3649

Merged
merged 5 commits into from
Dec 7, 2022
Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Dec 7, 2022

What do these changes do?

  • Fixes a typo in the retry arguments for tests/public-api/test_solvers_jobs_api.py
  • 📝 Extra docs and constants

@pcrespov pcrespov self-assigned this Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #3649 (74dbb9d) into master (3f8a317) will increase coverage by 9.5%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3649     +/-   ##
========================================
+ Coverage    74.1%   83.6%   +9.5%     
========================================
  Files         766     630    -136     
  Lines       31413   29063   -2350     
  Branches      784     413    -371     
========================================
+ Hits        23286   24315   +1029     
+ Misses       7933    4625   -3308     
+ Partials      194     123     -71     
Flag Coverage Δ
integrationtests 62.3% <ø> (?)
unittests 82.0% <100.0%> (+7.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rvice-library/src/servicelib/mimetype_constants.py 100.0% <100.0%> (ø)
...k/src/simcore_sdk/node_ports_v2/port_validation.py 47.9% <0.0%> (-48.0%) ⬇️
.../simcore-sdk/src/simcore_sdk/node_ports_v2/port.py 61.1% <0.0%> (-19.2%) ⬇️
...-sdk/src/simcore_sdk/node_ports_v2/nodeports_v2.py 85.0% <0.0%> (-8.0%) ⬇️
...sdk/src/simcore_sdk/node_ports_v2/ports_mapping.py 93.3% <0.0%> (-6.7%) ⬇️
.../simcore_sdk/node_ports_common/data_items_utils.py 93.7% <0.0%> (-6.3%) ⬇️
...core-sdk/src/simcore_sdk/node_ports_v2/__init__.py 95.2% <0.0%> (-4.8%) ⬇️
...re-sdk/src/simcore_sdk/node_ports_v2/port_utils.py 61.3% <0.0%> (-4.0%) ⬇️
...rc/simcore_sdk/node_ports_common/storage_client.py 77.7% <0.0%> (-3.8%) ⬇️
.../src/simcore_sdk/node_ports_v2/serialization_v2.py 82.1% <0.0%> (-3.6%) ⬇️
... and 473 more

@pcrespov pcrespov enabled auto-merge (squash) December 7, 2022 14:35
@sonarcloud
Copy link

sonarcloud bot commented Dec 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit 0cea2a5 into ITISFoundation:master Dec 7, 2022
@pcrespov pcrespov deleted the fix/api-tests branch December 7, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants