Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Autoscaling: have only one ec2 client #3643

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Dec 6, 2022

What do these changes do?

This PR refactors the Autoscaling service such that only 1 EC2 client is used in the application.

Also refactors modules to follow other fastapi-based services architecture

Related issue/s

relates to #3600

How to test

Checklist

@sanderegg sanderegg added this to the Zefram Cochrane milestone Dec 6, 2022
@sanderegg sanderegg self-assigned this Dec 6, 2022
@sanderegg sanderegg force-pushed the enhancement/autoscaling/one_ec2_client branch from 5268164 to d5af383 Compare December 6, 2022 21:36
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #3643 (8533555) into master (43192a2) will decrease coverage by 20.7%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3643      +/-   ##
=========================================
- Coverage    84.2%   63.4%   -20.8%     
=========================================
  Files         876     373     -503     
  Lines       37053   18678   -18375     
  Branches      784     135     -649     
=========================================
- Hits        31224   11859   -19365     
- Misses       5622    6770    +1148     
+ Partials      207      49     -158     
Flag Coverage Δ
integrationtests 62.4% <ø> (-5.1%) ⬇️
unittests 98.8% <100.0%> (+17.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ling/src/simcore_service_autoscaling/api/health.py 100.0% <100.0%> (ø)
...rc/simcore_service_autoscaling/core/application.py 100.0% <100.0%> (ø)
...ing/src/simcore_service_autoscaling/core/errors.py 100.0% <100.0%> (ø)
...imcore_service_autoscaling/dynamic_scaling_core.py 100.0% <100.0%> (ø)
...ing/src/simcore_service_autoscaling/modules/ec2.py 100.0% <100.0%> (ø)
...rc/simcore_service_autoscaling/modules/rabbitmq.py 100.0% <100.0%> (ø)
...aling/src/simcore_service_autoscaling/utils/ec2.py 100.0% <100.0%> (ø)
.../src/simcore_service_autoscaling/utils/rabbitmq.py 100.0% <100.0%> (ø)
...-v2/src/simcore_service_director_v2/cli/_client.py 0.0% <0.0%> (-100.0%) ⬇️
...v2/src/simcore_service_director_v2/cli/__init__.py 0.0% <0.0%> (-100.0%) ⬇️
... and 704 more

@sanderegg sanderegg force-pushed the enhancement/autoscaling/one_ec2_client branch from d5af383 to 23a7365 Compare December 7, 2022 21:17
@sanderegg sanderegg marked this pull request as ready for review December 7, 2022 21:17
@sanderegg sanderegg requested review from GitHK and mguidon December 7, 2022 21:17
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Some minor inputs below

@sanderegg sanderegg force-pushed the enhancement/autoscaling/one_ec2_client branch from a278239 to 51d3751 Compare December 8, 2022 09:28
@sanderegg sanderegg force-pushed the enhancement/autoscaling/one_ec2_client branch from 51d3751 to ca890ff Compare December 8, 2022 10:44
@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg merged commit 0f04727 into ITISFoundation:master Dec 8, 2022
@sanderegg sanderegg deleted the enhancement/autoscaling/one_ec2_client branch December 8, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants