-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Autoscaling: have only one ec2 client #3643
✨ Autoscaling: have only one ec2 client #3643
Conversation
5268164
to
d5af383
Compare
Codecov Report
@@ Coverage Diff @@
## master #3643 +/- ##
=========================================
- Coverage 84.2% 63.4% -20.8%
=========================================
Files 876 373 -503
Lines 37053 18678 -18375
Branches 784 135 -649
=========================================
- Hits 31224 11859 -19365
- Misses 5622 6770 +1148
+ Partials 207 49 -158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d5af383
to
23a7365
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Some minor inputs below
services/autoscaling/src/simcore_service_autoscaling/api/health.py
Outdated
Show resolved
Hide resolved
a278239
to
51d3751
Compare
51d3751
to
ca890ff
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
This PR refactors the Autoscaling service such that only 1 EC2 client is used in the application.
Also refactors modules to follow other fastapi-based services architecture
Related issue/s
relates to #3600
How to test
Checklist