Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: close Preparing Inputs window #3642

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Dec 6, 2022

What do these changes do?

In order not to accumulate too many TIP studies in puppeteer's account, if TIP e2e test fails because the optimizer times out, close the "Preparing Inputs" view before going back to the dashboard

@odeimaiz odeimaiz self-assigned this Dec 6, 2022
@odeimaiz odeimaiz added this to the Zefram Cochrane milestone Dec 6, 2022
@odeimaiz odeimaiz added the e2e Bugs found by or related to the end-2-end testing label Dec 6, 2022
@odeimaiz odeimaiz changed the title close Preparing Inputs window e2e: close Preparing Inputs window Dec 6, 2022
@odeimaiz odeimaiz enabled auto-merge (squash) December 6, 2022 16:10
@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@odeimaiz odeimaiz merged commit 6a8d3be into ITISFoundation:master Dec 7, 2022
@odeimaiz odeimaiz deleted the e2e/tip-minor-fix branch December 7, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants