✅ Is3569/flaky public api test #3634

pcrespov · 2022-12-01T18:09:56Z

What do these changes do?

Fixes flaky test in public api: the logfile sometimes is not ready and fails with 404. We retry a few times before giving up

Related issue/s

closes Flaky tests/public-api/test_solvers_jobs_api.py::test_run_job[FAILED] #3569

sanderegg

nice! thanks!

codecov · 2022-12-01T18:32:43Z

Codecov Report

Merging #3634 (ae8b36a) into master (4b2db6c) will decrease coverage by 16.7%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #3634      +/-   ##
=========================================
- Coverage    84.1%   67.4%   -16.8%     
=========================================
  Files         868     355     -513     
  Lines       36555   18128   -18427     
  Branches      782     133     -649     
=========================================
- Hits        30763   12223   -18540     
- Misses       5585    5856     +271     
+ Partials      207      49     -158

Flag	Coverage Δ
integrationtests	`67.4% <ø> (+<0.1%)`	⬆️
unittests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...-v2/src/simcore_service_director_v2/cli/_client.py	`0.0% <0.0%> (-100.0%)`	⬇️
...v2/src/simcore_service_director_v2/cli/__init__.py	`0.0% <0.0%> (-100.0%)`	⬇️
...service_webserver/projects/_project_models_rest.py	`0.0% <0.0%> (-100.0%)`	⬇️
...service_director_v2/cli/_close_and_save_service.py	`0.0% <0.0%> (-100.0%)`	⬇️
...es/web/server/src/simcore_service_webserver/log.py	`0.0% <0.0%> (-94.8%)`	⬇️
...erver/src/simcore_service_webserver/rest_models.py	`0.0% <0.0%> (-92.7%)`	⬇️
...or-v2/src/simcore_service_director_v2/cli/_core.py	`0.0% <0.0%> (-87.5%)`	⬇️
...simcore_service_webserver/director/director_api.py	`0.0% <0.0%> (-76.0%)`	⬇️
...ce_director_v2/modules/db/repositories/clusters.py	`23.0% <0.0%> (-71.7%)`	⬇️
...rc/simcore_service_webserver/version_control_db.py	`24.5% <0.0%> (-68.7%)`	⬇️
... and 693 more