✨Improve phone registration #3624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
a:frontend
odeimaiz
requested review from
pcrespov,
mrnicegyu11,
sanderegg,
elisabettai,
GitHK,
ignapas and
mguidon
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
We had a couple of users hitting a wall at the phone registration step. Apparently, the phone number validation method is not enough.
In order to make the phone number registration process smoother, this PR integrates the third party intl-tel-input library. This library converts a phone-input field into a form with a list of countries, and their country codes, together with a placeholder for each case. It also provides a method to convert user specified phone number to E.164 format, required by our Messaging service.
Related issue/s
Improves 2FA ITISFoundation/osparc-issues#765
How to test
Checklist