-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Rocket-lite Navigation Bar review #3619
Merged
odeimaiz
merged 18 commits into
ITISFoundation:master
from
odeimaiz:feature/s4l-lite-study-editor
Dec 1, 2022
Merged
✨ Rocket-lite Navigation Bar review #3619
odeimaiz
merged 18 commits into
ITISFoundation:master
from
odeimaiz:feature/s4l-lite-study-editor
Dec 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
a:frontend
issue affecting the front-end (area group)
changelog:🎨enhancement
labels
Nov 29, 2022
odeimaiz
changed the title
✨ Rocket lite Navigation Bar review
✨ Rocket-lite Navigation Bar review
Nov 29, 2022
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
odeimaiz
requested review from
colinRawlings,
GitHK,
ignapas,
mguidon,
mrnicegyu11 and
sanderegg
December 1, 2022 15:31
pcrespov
approved these changes
Dec 1, 2022
sanderegg
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Once the user starts a study in the rocket-lite product, since the service starts in full screen mode, many functionalities get hidden. This PR brings the most important ones to the Navigation Bar:
Related issue/s
Improves Full Screen UX ITISFoundation/osparc-issues#765