Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ React to study:open 409 error code #3618

Merged
merged 4 commits into from
Nov 29, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 29, 2022

What do these changes do?

This PR implements the frontend part of this PR

OneStudyMax

Related issue/s

Restrict users to open only one study: ITISFoundation/osparc-issues#765

How to test

Checklist

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🎨enhancement labels Nov 29, 2022
@odeimaiz odeimaiz added this to the Athena milestone Nov 29, 2022
@odeimaiz odeimaiz self-assigned this Nov 29, 2022
@odeimaiz odeimaiz marked this pull request as ready for review November 29, 2022 14:55
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! thanks! a lot!

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #3618 (78365ed) into master (5d3fdaa) will decrease coverage by 1.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3618      +/-   ##
=========================================
- Coverage    83.0%   81.8%    -1.2%     
=========================================
  Files         866     355     -511     
  Lines       36478   18094   -18384     
  Branches      782     133     -649     
=========================================
- Hits        30301   14814   -15487     
+ Misses       5970    3231    -2739     
+ Partials      207      49     -158     
Flag Coverage Δ
integrationtests 52.1% <ø> (-8.6%) ⬇️
unittests 82.9% <ø> (+1.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._service_webserver/projects/projects_exceptions.py 94.5% <ø> (ø)
...-v2/src/simcore_service_director_v2/cli/_client.py 0.0% <0.0%> (-100.0%) ⬇️
...v2/src/simcore_service_director_v2/cli/__init__.py 0.0% <0.0%> (-100.0%) ⬇️
...service_director_v2/cli/_close_and_save_service.py 0.0% <0.0%> (-100.0%) ⬇️
...or-v2/src/simcore_service_director_v2/cli/_core.py 0.0% <0.0%> (-87.5%) ⬇️
...ce_director_v2/modules/db/repositories/clusters.py 23.0% <0.0%> (-71.7%) ⬇️
...imcore_service_webserver/exporter/export_import.py 34.1% <0.0%> (-63.5%) ⬇️
...vice_webserver/exporter/formatters/formatter_v2.py 31.9% <0.0%> (-58.6%) ⬇️
...ervice_director_v2/api/routes/dynamic_scheduler.py 38.2% <0.0%> (-57.4%) ⬇️
...vice_webserver/exporter/formatters/formatter_v1.py 27.6% <0.0%> (-55.9%) ⬇️
... and 603 more

@odeimaiz odeimaiz enabled auto-merge (squash) November 29, 2022 15:06
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odeimaiz odeimaiz merged commit 9152bf8 into ITISFoundation:master Nov 29, 2022
@odeimaiz odeimaiz deleted the feature/max-studies branch August 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants