✨Autoscaling: automatically cleanup nodes from the docker swarm #3617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
force-pushed
the
enhancement/autoscaling/cleanup_nodes
branch
from
90043c1 to
9102304
Compare
Codecov Report
@@ Coverage Diff @@
## master #3617 +/- ##
======================================
Coverage 84.0% 84.0%
======================================
Files 853 853
Lines 36155 36155
Branches 782 782
======================================
Hits 30394 30394
Misses 5554 5554
Partials 207 207
Flags with carried forward coverage won't be shown. Click here to find out more. |
pcrespov
approved these changes
Nov 29, 2022
sanderegg
force-pushed
the
enhancement/autoscaling/cleanup_nodes
branch
from
58cdbac to
0612edf
Compare
sanderegg
force-pushed
the
enhancement/autoscaling/cleanup_nodes
branch
from
0612edf to
d626ab5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR removes the "Down" monitored nodes from the docker node list on the manager, to keep things tidy.
Bonus: better wait for services to go down (should remove flakyness in autoscaling tests)
Related issue/s
How to test
Checklist