Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Simple readable agent logs (⚠️ devops) #3599

Merged
merged 4 commits into from
Nov 25, 2022

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 24, 2022

⚠️ devops

  • raise default log level of the agent service from info to warning
  • change current Alert osparc.speag.com: Zombie dy-volumes detected and saved offsite triggered: from oSparc Batman channel to only trigger if a message similar to the one below is displayed.

What do these changes do?

Reformatted the logged message to help when debugging

WARNING: [2022-11-24 14:56:12,542/MainProcess] [simcore_service_agent.modules.volumes_cleanup._s3:_log_expected_operation(114)]  -
---
Volume data
---
volume_name         dyv_dec678f4-267b-4cc7-a210-b9483c0b725e_91938524-b241-4182-bf2e-a153fd515686_emulov_desunu_03s_ot_erots_tset_15-tsetyp_khtnelis-fo-tsetyp_pmt_
destination_path    /test-bucket-9857e407-0ce9-46e2-8253-0097b9bfe29a/test-simcore/3d4b967e-8de7-4049-b05d-73cc7d169edc/91938524-b241-4182-bf2e-a153fd515686/dec678f4-267b-4cc7-a210-b9483c0b725e/tmp_pytest-of-silenthk_pytest-51_test_store_to_s30_unused_volume
study_id:           3d4b967e-8de7-4049-b05d-73cc7d169edc
node_id:            91938524-b241-4182-bf2e-a153fd515686
user_id:            1
run_id:             dec678f4-267b-4cc7-a210-b9483c0b725e
---
Files to sync by rclone
---
4 f1.txt
4 f2.txt
4 f3.txt
4 d1/f1.txt
4 d1/f2.txt
4 d1/f3.txt
4 d1/sd1/f1.txt
4 d1/sd1/f2.txt
4 d1/sd1/f3.txt
---

Related issue/s

How to test

Checklist

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #3599 (0c7e3c3) into master (1bca2e5) will decrease coverage by 20.7%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3599      +/-   ##
=========================================
- Coverage    83.6%   62.9%   -20.8%     
=========================================
  Files         861     368     -493     
  Lines       36225   18399   -17826     
  Branches      779     133     -646     
=========================================
- Hits        30314   11578   -18736     
- Misses       5706    6772    +1066     
+ Partials      205      49     -156     
Flag Coverage Δ
integrationtests 62.3% <ø> (-5.2%) ⬇️
unittests 95.3% <100.0%> (+14.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mcore_service_agent/modules/volumes_cleanup/_s3.py 98.2% <100.0%> (+0.1%) ⬆️
...-v2/src/simcore_service_director_v2/cli/_client.py 0.0% <0.0%> (-100.0%) ⬇️
...v2/src/simcore_service_director_v2/cli/__init__.py 0.0% <0.0%> (-100.0%) ⬇️
...service_webserver/projects/_project_models_rest.py 0.0% <0.0%> (-100.0%) ⬇️
...service_director_v2/cli/_close_and_save_service.py 0.0% <0.0%> (-100.0%) ⬇️
...es/web/server/src/simcore_service_webserver/log.py 0.0% <0.0%> (-94.8%) ⬇️
...erver/src/simcore_service_webserver/rest_models.py 0.0% <0.0%> (-92.7%) ⬇️
...or-v2/src/simcore_service_director_v2/cli/_core.py 0.0% <0.0%> (-87.5%) ⬇️
...rc/simcore_service_director_v2/utils/dict_utils.py 16.1% <0.0%> (-83.9%) ⬇️
...v2/modules/dynamic_sidecar/docker_compose_specs.py 22.2% <0.0%> (-77.8%) ⬇️
... and 689 more

@GitHK GitHK self-assigned this Nov 24, 2022
@GitHK GitHK added this to the Athena milestone Nov 24, 2022
@GitHK GitHK marked this pull request as ready for review November 24, 2022 14:06
@GitHK GitHK enabled auto-merge (squash) November 25, 2022 07:25
@sonarcloud
Copy link

sonarcloud bot commented Nov 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@GitHK GitHK merged commit 491a354 into ITISFoundation:master Nov 25, 2022
@GitHK GitHK deleted the pr-osparc-agent-better-logging branch November 25, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:agent agent service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants