Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request service frontend after successful ping #3598

Merged
merged 3 commits into from
Nov 24, 2022
Merged

Request service frontend after successful ping #3598

merged 3 commits into from
Nov 24, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 24, 2022 •
edited
Loading

What do these changes do?

Once the backend tells the frontend that a dynamic service is ready and provides the service url, the frontend pings it to really make sure that it is responsive.

In some cases this is not enough, this PR adds one more check after the successful ping.

The process is the following

  • The backend set the service state to ready
  • The backend provides the service url
  • The frontend pings the service url until it receives a successful response
  • New: In order to make sure that everything is set, the frontend requests (and retries) the service website.
  • The iframe is loaded and it requests the service website

Bonus:

While the service is loading, show service's thumbnail instead of vendor's logo

RetryAndLogo

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz self-assigned this Nov 24, 2022
@odeimaiz odeimaiz added this to the Athena milestone Nov 24, 2022
@odeimaiz odeimaiz changed the title Feature/retry after ping Request service frontend after successful ping Nov 24, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odeimaiz odeimaiz enabled auto-merge (squash) November 24, 2022 12:45
mrnicegyu11
mrnicegyu11 approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

elisabettai
elisabettai approved these changes Nov 24, 2022
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for quick fix!

@odeimaiz odeimaiz merged commit 95d4e91 into ITISFoundation:master Nov 24, 2022
pcrespov pushed a commit that referenced this pull request Nov 24, 2022
@odeimaiz @pcrespov
Request service frontend after successful ping (#3598)
0c81683
@sanderegg sanderegg mentioned this pull request Dec 1, 2022
Closed
pcrespov pushed a commit that referenced this pull request Dec 2, 2022
@odeimaiz @pcrespov
Request service frontend after successful ping (#3598)
b991f6b
@odeimaiz odeimaiz deleted the feature/retry-after-ping branch August 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov approved these changes

@elisabettai elisabettai elisabettai approved these changes

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg

@GitHK GitHK Awaiting requested review from GitHK

Assignees

@odeimaiz odeimaiz

Labels
None yet
Projects
None yet
Milestone
Athena
Development

Successfully merging this pull request may close these issues.
5 participants
@odeimaiz @mrnicegyu11 @elisabettai @pcrespov @sanderegg