♻️ Is3318/refactoring websever.login plugin (2/3)

[pcrespov]

What do these changes do?

Follows from #3577 and is mostly a refactoring of the login plugin and some preparations to send 2FA codes via email.

• ♻️ refactoring of login plugin
  • Cleanup login plugin's settings (moved all messages to login._constants
  • Using pg transactions for atomic delete (to avoid inconsistent states)
  • Enhanced error handling
    • OECs when unexpected errors (e.g. emails failures)
    • for failures on email confirmation links, redirection to front-end error-page
    • request validation errors transformed from ValidationError to 422
  • Removes dependencies from openapi-core:
    • adds routes=RouteTableDef() decorators to login handlers.
    • replaces extract_and_validate with servicelib.aiohttp.requests_validation and pydantic models which in addition are used to create the OAS
• ♻️ moved most test_login to services/web/server/tests/unit/with_dbs/03/login, cleaned and extended.
• ♻️ refactoring of email plugin setup
• web-server API 0.12.0 → 0.12.2
• ✨ Adds services/web/server/src/simcore_service_webserver/templates/common/new_2fa_code.jinja2 email template

Next PR will implement

• new entrypoint to resend 2FA code (via email or SMS)
• restrict access to login_2fa, register_phone and phone_confirmation handlers (via temporary access codes in session cookies)

Further improvements (subsequent PRs)

• Increase Password requirements #2480
• session cookie expiration + secured
• geo location of ips
• GC task to clean old CONFIRMATION_PENDING users and invalid CONFIRMATION?
• move auto_add_user_to_groups to email_confirmation when the latter is required.
• username (as identity)+ multiple emails?

Related issue/s

• Implementing Resend phone confirmation code #3318

How to test

cd services/web/server
make install-dev
pytest  tests/unit/with_dbs/03/login

Checklist

• rm all MSG_ constants from config
• Use models from pydantic validation of requests
• unique user-name _get_user_name
• check auto_add_user_to_groups with @sanderegg
• Atomic transactions to avoid inconsistent states of data
• make version-*
• make openapi.json
• cd packages/postgres-database, make setup-commit, sc-pg review -m "my changes"
• Unit tests for the changes exist
• Runs in the swarm
• Documentation reflects the changes
• New module? Add your github username to .github/CODEOWNERS

[codecov]

Codecov Report

Merging #3590 (c08c261) into master (0f04727) will decrease coverage by 2.3%.
The diff coverage is 87.6%.

@@           Coverage Diff            @@
##           master   #3590     +/-   ##
========================================
- Coverage    82.3%   79.9%   -2.4%     
========================================
  Files         763     880    +117     
  Lines       33745   37179   +3434     
  Branches      778     785      +7     
========================================
+ Hits        27792   29728   +1936     
- Misses       5746    7243   +1497     
- Partials      207     208      +1     

Flag	Coverage Δ
integrationtests	62.7% <57.9%> (+15.5%)	⬆️
unittests	77.5% <87.6%> (-3.8%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...server/src/simcore_service_webserver/_constants.py	100.0% <ø> (ø)
...server/src/simcore_service_webserver/login/_sql.py	96.0% <ø> (ø)
...rver/src/simcore_service_webserver/login/routes.py	100.0% <ø> (ø)
...er/src/simcore_service_webserver/login/settings.py	96.5% <ø> (-3.5%)	⬇️
...c/simcore_service_webserver/login/_registration.py	84.7% <40.0%> (+1.3%)	⬆️
.../web/server/src/simcore_service_webserver/email.py	92.8% <50.0%> (+6.4%)	⬆️
...ver/src/simcore_service_webserver/utils_aiohttp.py	81.3% <58.3%> (-12.6%)	⬇️
...ver/src/simcore_service_webserver/login/storage.py	94.2% <63.6%> (-5.8%)	⬇️
...rary/src/servicelib/aiohttp/requests_validation.py	92.6% <66.6%> (-4.8%)	⬇️
...src/simcore_service_webserver/login/utils_email.py	67.0% <66.6%> (+1.2%)	⬆️
... and 216 more

[sanderegg]

great! and thanks for moving the tests to their own folder

[odeimaiz]

👌

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication