♻️ Replaces SMTP_SENDER by the products email (⚠️ devops)

[pcrespov]

What do these changes do?

This PR implements #3305: Emails now use product support email instead of SMTP_SENDER env var. The latter has been removed.

In addition:

• ♻️ refactors publication plugin
  • cleanup implementation: annotations, extra checks, deleted test flags.
  • upgraded to route decorator
  • adds 03/tests_publications.py
• 🔨 improves e2e logs and fixes links in main README.md
• ♻️ renames get_dynamic_services as list_dynamic_services (to distinguish from get_dynamic_service)

⚠️ devops

• removes env var SMTP_SENDER and replaces it by the column products.support_email in the database.
• ⚠️ since we do not have an emulator for the email server , it should be manually tested when deployed !! Please report back to this issue.

Related issue/s

• closes Refactoring request: Move SMTP_SENDER to pgSQL products table #3305

How to test

cd services/web/server
make install-dev
make test-dev-unit

Checklist

• Unit tests for the changes exist
• Runs in the swarm
• Documentation reflects the changes

[codecov]

Codecov Report

Merging #3576 (559d1b7) into master (db493ed) will increase coverage by 0.6%.
The diff coverage is 70.2%.

@@           Coverage Diff            @@
##           master   #3576     +/-   ##
========================================
+ Coverage    83.3%   83.9%   +0.6%     
========================================
  Files         861     677    -184     
  Lines       36229   29920   -6309     
  Branches      779     270    -509     
========================================
- Hits        30198   25130   -5068     
+ Misses       5827    4712   -1115     
+ Partials      204      78    -126     

Flag	Coverage Δ
integrationtests	67.4% <29.7%> (+1.7%)	⬆️
unittests	80.5% <70.2%> (-0.3%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ges/settings-library/src/settings_library/email.py	94.4% <ø> (-0.2%)	⬇️
...re_service_webserver/application_settings_utils.py	97.7% <ø> (-0.1%)	⬇️
...r/src/simcore_service_webserver/director_v2_api.py	100.0% <ø> (ø)
...e_service_webserver/login/handlers_registration.py	85.2% <ø> (ø)
...er/src/simcore_service_webserver/login/settings.py	100.0% <ø> (ø)
...simcore_service_webserver/login/handlers_change.py	86.8% <33.3%> (+0.1%)	⬆️
.../simcore_service_webserver/publication_handlers.py	32.0% <36.3%> (+2.5%)	⬆️
...imcore_service_webserver/garbage_collector_core.py	69.2% <50.0%> (+6.6%)	⬆️
...src/simcore_service_webserver/login/utils_email.py	65.8% <92.8%> (+2.2%)	⬆️
...ice_webserver/director_v2_core_dynamic_services.py	69.3% <100.0%> (ø)
... and 199 more

[sanderegg]

great! thanks also for the changes in the director-v2

[mrnicegyu11]

ack

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication